From: peter.ujfalusi@ti•com (Peter Ujfalusi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency
Date: Wed, 25 Feb 2015 17:31:47 +0200 [thread overview]
Message-ID: <54EDEAE3.6080605@ti.com> (raw)
In-Reply-To: <22890811.0MuvZ4MxOU@wuerfel>
On 02/25/2015 05:05 PM, Arnd Bergmann wrote:
> The change to enable OMAP5 support on this platform was a little too
> eager in adding a 'select' for a particular clock driver that might
> not be enabled in all configurations, which in turn leads to a build
> error:
>
> warning: (SND_OMAP_SOC_OMAP_ABE_TWL6040) selects COMMON_CLK_PALMAS which has unmet direct dependencies (COMMON_CLK && MFD_PALMAS)
> drivers/built-in.o: In function `palmas_clks_probe':
> drivers/clk/clk-palmas.c:228: undefined reference to `palmas_ext_control_req_config'
>
> I do not see a strong dependency here, so it's probably better to
> drop this select and to avoid adding more complexity here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> Fixes: 5163c1eede8e9 ("ASoC: omap: Kconfig: Support for omap5-uevm analog audio")
>
> diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
> index e7c78b0406b5..e74d8db4619d 100644
> --- a/sound/soc/omap/Kconfig
> +++ b/sound/soc/omap/Kconfig
> @@ -105,7 +105,6 @@ config SND_OMAP_SOC_OMAP_ABE_TWL6040
> select SND_OMAP_SOC_MCPDM
> select SND_SOC_TWL6040
> select SND_SOC_DMIC
> - select COMMON_CLK_PALMAS if SOC_OMAP5
Would it be better to have this changed to:
select COMMON_CLK_PALMAS if MFD_PALMAS
instead of removing.
All OMAP5 boards uses Palmas as PMIC and the boards where twl6040 audio is in
use the 32K clock for the codec is coming from Palmas.
Without this clock the twl6040 will not boot up causing errors during probe time.
> help
> Say Y if you want to add support for SoC audio on OMAP boards using
> ABE and twl6040 codec. This driver currently supports:
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
P?ter
next prev parent reply other threads:[~2015-02-25 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 15:05 [PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency Arnd Bergmann
2015-02-25 15:31 ` Peter Ujfalusi [this message]
2015-02-25 15:42 ` [PATCH v2] " Arnd Bergmann
2015-02-26 15:08 ` Peter Ujfalusi
2015-03-06 19:50 ` Mark Brown
2015-02-25 15:44 ` [PATCH] " Arnd Bergmann
2015-02-26 2:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EDEAE3.6080605@ti.com \
--to=peter.ujfalusi@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox