From: peter@hurleysoftware•com (Peter Hurley)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 3/3] of: support passing console options with stdout-path
Date: Thu, 26 Feb 2015 09:09:55 -0500 [thread overview]
Message-ID: <54EF2933.3020408@hurleysoftware.com> (raw)
In-Reply-To: <20150226134646.GB8806@lunn.ch>
Hi Andrew,
On 02/26/2015 08:46 AM, Andrew Lunn wrote:
> On Thu, Feb 26, 2015 at 06:55:22AM -0500, Peter Hurley wrote:
>> On 11/27/2014 12:56 PM, Leif Lindholm wrote:
>>> Support specifying console options (like with console=ttyXN,<options>)
>>> by appending them to the stdout-path property after a separating ':'.
>>>
>>> Example:
>>> stdout-path = "uart0:115200";
>>
>> This format breaks DT earlycon because libfdt doesn't recognize ':' as a
>> path terminator.
>>
>> It's simple enough to fix this directly in early_init_dt_scan_chosen_serial()
>> but perhaps it would better to teach fdt_path_offset() to recognize ':'?
>
> Hi Peter
>
> ePAPR says for stdout-path in Chosen:
>
> A string that specifies the full path to the node representing the
> device to be used for boot console output. If the character ":" is
> present in the value it terminates the path. The value may be an
> alias.
>
> So it is probably wise to implement this properly.
Sorry if I was unclear. My question was not _whether_ to fix this
for earlycon, but rather _how_.
IOW, is the ':' character accepted as a path terminator for
1. all nodes, so fix this in fdt_path_offset();
2. only chosen nodes;
3. unique to stdout-path, so fix this in early_init_dt_scan_chosen_serial()?
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-02-26 14:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 17:56 [PATCH v3 0/3] of: support passing console options with stdout-path Leif Lindholm
2014-11-27 17:56 ` [PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path Leif Lindholm
2014-11-27 18:41 ` Mark Rutland
2014-11-28 0:22 ` Grant Likely
2014-12-03 2:24 ` Frank Rowand
2014-12-03 15:12 ` Grant Likely
2014-12-03 19:46 ` Frank Rowand
2014-12-03 21:45 ` Grant Likely
2014-12-03 23:07 ` Frank Rowand
2014-12-04 10:39 ` Grant Likely
2014-11-27 17:56 ` [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path() Leif Lindholm
2014-11-28 0:44 ` Grant Likely
2014-11-28 11:34 ` Leif Lindholm
2014-11-28 15:25 ` Grant Likely
2014-11-28 15:33 ` Grant Likely
2014-11-28 16:38 ` [PATCH v3 2/3] of: add optional options parameter to? of_find_node_by_path() Leif Lindholm
2014-11-28 23:57 ` Grant Likely
2015-03-04 15:45 ` [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path() Peter Hurley
2015-03-06 16:52 ` Leif Lindholm
2015-03-06 18:11 ` Peter Hurley
2015-03-06 18:59 ` Peter Hurley
2015-03-13 15:23 ` Rob Herring
2014-11-27 17:56 ` [PATCH v3 3/3] of: support passing console options with stdout-path Leif Lindholm
2014-11-28 15:39 ` Grant Likely
2015-02-26 11:55 ` Peter Hurley
2015-02-26 13:46 ` Andrew Lunn
2015-02-26 14:09 ` Peter Hurley [this message]
2015-02-26 14:44 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EF2933.3020408@hurleysoftware.com \
--to=peter@hurleysoftware$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox