From: fbf@libero•it (Fulvio)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] cpuidle: mvebu: Fix the CPU PM notifier usage
Date: Tue, 03 Mar 2015 11:52:53 +0100 [thread overview]
Message-ID: <54F59285.5060306@libero.it> (raw)
In-Reply-To: <54F58E3B.9040302@free-electrons.com>
Gregory CLEMENT wrote:
> Hi Rafael,
>
>
>
> On 03/03/2015 11:30, Daniel Lezcano wrote:
>
>> On 02/27/2015 10:39 AM, Gregory CLEMENT wrote:
>>
>>> Hi Rafael,
>>>
>>> On 26/02/2015 22:55, Rafael J. Wysocki wrote:
>>>
>>>> On Thursday, February 26, 2015 06:20:48 PM Gregory CLEMENT wrote:
>>>>
>>>>> As stated in kernel/cpu_pm.c, "Platform is responsible for ensuring
>>>>> that cpu_pm_enter is not called twice on the same CPU before
>>>>> cpu_pm_exit is called.". In the current code in case of failure when
>>>>> calling mvebu_v7_cpu_suspend, the function cpu_pm_exit() is never
>>>>> called whereas cpu_pm_enter() was called just before.
>>>>>
>>>>> This patch moves the cpu_pm_exit() in order to balance the
>>>>> cpu_pm_enter() calls.
>>>>>
>>>>> Reported-by: Fulvio Benini <fbf@libero•it>
>>>>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>>>>>
>>>> Should that go to "stable" too? Which "stable" series it should go to if so?
>>>>
>>> Yes as it fixes a potential issue, you're right it should go
>>> to "stable". The bug was here since the introduction of the driver
>>> in 3.16.
>>>
>> Hi Gregory,
>>
>> actually the 'stable' rules state clearly:
>>
>> "- It must fix a real bug that bothers people (not a, "This could be a
>> problem..." type thing)."
>>
>> You say "it fixes a potential issue", so no bug has been raise yet, right ?
>>
>
> Indeed nobody claimed yet having a bug related to this issue.
>
> Gregory
>
>
I reported the issue, but i cannot say if it's a real bug.
I had random kernel panics with a Netgear ReadyNAS RN102 (armada 370 cpu):
http://www.readynas.com/forum/viewtopic.php?f=20&t=78697&sid=14747617286d55ac27296cdee7a3f420&start=210#p452214
All i can say is that the system use the "armadaxp_idle" driver and
works fine when running "stress --cpu 8" in background.
I asked Netgear to provide a firmware without the idle driver to confirm
if it's the cause of the problem, but they did not answered.
Bye,
Fulvio
next prev parent reply other threads:[~2015-03-03 10:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 17:20 [PATCH] cpuidle: mvebu: Fix the CPU PM notifier usage Gregory CLEMENT
2015-02-26 21:55 ` Rafael J. Wysocki
2015-02-27 9:39 ` Gregory CLEMENT
2015-03-03 10:30 ` Daniel Lezcano
2015-03-03 10:34 ` Gregory CLEMENT
2015-03-03 10:52 ` Fulvio [this message]
2015-03-03 11:12 ` Daniel Lezcano
2015-03-03 12:51 ` Gregory CLEMENT
2015-03-03 13:00 ` Daniel Lezcano
2015-03-03 14:58 ` Fulvio
2015-03-03 15:20 ` Daniel Lezcano
2015-03-04 14:53 ` Rafael J. Wysocki
2015-03-04 14:34 ` Daniel Lezcano
2015-02-27 16:50 ` Daniel Lezcano
2015-02-27 22:18 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F59285.5060306@libero.it \
--to=fbf@libero$(echo .)it \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox