From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] ARM: BCM2835: Add a function for doing an rmb() between device reads.
Date: Mon, 16 Mar 2015 21:24:41 -0600 [thread overview]
Message-ID: <55079E79.6030303@wwwdotorg.org> (raw)
In-Reply-To: <1426213936-4139-1-git-send-email-eric@anholt.net>
On 03/12/2015 08:32 PM, Eric Anholt wrote:
> Stephen Warren was concerned that the rmb() present in the new mailbox
> driver was unnecessary, and after seeing the docs, that it was just so
> surprising that somebody would come along and remove it later. The
> explanation for the need for the rmb() is long enough that we won't
> want to place it at every callsite. Make a wrapper with the whole
> explanation in it, so that anyone wondering what's going on sees the
> docs right there.
> diff --git a/include/soc/bcm2835/peripheral-workaround.h b/include/soc/bcm2835/peripheral-workaround.h
> +static inline void bcm2835_peripheral_read_workaround(void)
> +{
> +#ifdef CONFIG_ARCH_BCM2835
Would this header be included if that wasn't defined? Perhaps that'll be
answered by a later patch...
> + /*
> + * The BCM2835 bus is unusual in that it doesn't guarantee
> + * ordering between reads from different peripherals (where
> + * peripherals roughly correspond to Linux devices). From
> + * BCM2835 ARM Peripherals.pdf, page 7:
Many buses don't guarantee ordering; that's quite common. The issue is
that the CPU then doesn't match up the correct read request and
response, thus causing it to swap the results of read requests. That's
the unusual part. It would be useful to spell that out more explicitly
in this introduction, even though it is called out in the example below.
BTW, the ARM mailing list is linux-arm-kernel at lists.infradead.org not
linux-arm-kernel at vger.kernel.org.
next parent reply other threads:[~2015-03-17 3:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426213936-4139-1-git-send-email-eric@anholt.net>
2015-03-17 3:24 ` Stephen Warren [this message]
2015-03-17 19:06 ` [PATCH 1/4] ARM: BCM2835: Add a function for doing an rmb() between device reads Eric Anholt
[not found] ` <1426213936-4139-3-git-send-email-eric@anholt.net>
2015-03-17 3:33 ` [PATCH 3/4 v4] mailbox: Enable BCM2835 mailbox support Stephen Warren
2015-03-17 18:05 ` Lee Jones
2015-03-17 19:04 ` Eric Anholt
2015-03-18 23:28 ` Eric Anholt
2015-03-20 4:48 ` Stephen Warren
2015-03-20 5:12 ` Jassi Brar
2015-03-20 17:38 ` Eric Anholt
2015-03-20 17:24 ` Eric Anholt
2015-03-20 19:29 ` Stephen Warren
[not found] ` <20150318084255.GJ3318@x1>
[not found] ` <87bnjqorpe.fsf@eliezer.anholt.net>
2015-03-20 4:44 ` Stephen Warren
[not found] ` <20150319075836.GU3318@x1>
2015-03-20 4:46 ` Stephen Warren
[not found] ` <1426213936-4139-4-git-send-email-eric@anholt.net>
2015-03-17 3:34 ` [PATCH 4/4] ARM: bcm2835: Add the mailbox to the device tree Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55079E79.6030303@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox