From: hdegoede@redhat•com (Hans de Goede)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY
Date: Thu, 19 Mar 2015 12:10:25 +0100 [thread overview]
Message-ID: <550AAEA1.5080301@redhat.com> (raw)
In-Reply-To: <1426728222-8197-5-git-send-email-computersforpeace@gmail.com>
Hi,
On 19-03-15 02:23, Brian Norris wrote:
> Signed-off-by: Brian Norris <computersforpeace@gmail•com>
> ---
> Light dependency on:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/331921.html
> for the surrounding text.
>
> arch/arm/boot/dts/bcm7445.dtsi | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm7445.dtsi b/arch/arm/boot/dts/bcm7445.dtsi
> index 9eaeac8dce1b..7a7c4d8c2afe 100644
> --- a/arch/arm/boot/dts/bcm7445.dtsi
> +++ b/arch/arm/boot/dts/bcm7445.dtsi
> @@ -108,6 +108,42 @@
> brcm,int-map-mask = <0x25c>, <0x7000000>;
> brcm,int-fwd-mask = <0x70000>;
> };
> +
> + sata at f045a000 {
> + compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci";
> + reg-names = "ahci", "top-ctrl";
> + reg = <0x45a000 0xa9c>, <0x458040 0x24>;
Why not simply drop the second register range here, and the minimal top-ctrl
poking you need in the phy driver's phy_init function ?
This avoids the weird / ugly register overlap with the phy driver, and I think you
can then just use the ahci_platform driver unmodified.
> + interrupts = <GIC_SPI 30 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sata0: sata-port at 0 {
> + reg = <0>;
> + phys = <&sata_phy 0>;
> + };
> +
> + sata1: sata-port at 1 {
> + reg = <1>;
> + phys = <&sata_phy 1>;
> + };
> + };
> +
> + sata_phy: sata-phy at f0458100 {
> + compatible = "brcm,bcm7445-sata-phy", "brcm,phy-sata3";
> + reg = <0x458100 0x1e00>, <0x45804c 0x10>;
Why not simply use: reg = <0x458000 0x2000>, to me it seems that what you should
really be using here.
> + reg-names = "phy", "port-ctrl";
> + #phy-cells = <1>;
> + #address-cells = <0x1>;
> + #size-cells = <0x0>;
> +
> + sata-phy at 0 {
> + reg = <0>;
> + };
> +
> + sata-phy at 1 {
> + reg = <1>;
> + };
> + };
> };
>
> smpboot {
>
Regards,
Hans
next prev parent reply other threads:[~2015-03-19 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 1:23 [PATCH 1/5] Documentation: devicetree: add Broadcom SATA binding Brian Norris
2015-03-19 1:23 ` [PATCH 2/5] Documentation: devicetree: add Broadcom SATA PHY binding Brian Norris
2015-03-19 1:23 ` [PATCH 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips Brian Norris
2015-03-20 22:58 ` Florian Fainelli
2015-03-19 1:23 ` [PATCH 4/5] phy: add Broadcom SATA3 PHY driver for Broadcom STB SoCs Brian Norris
2015-03-20 23:02 ` Florian Fainelli
2015-03-21 9:09 ` Hans de Goede
2015-03-25 21:59 ` Kishon Vijay Abraham I
2015-03-28 0:28 ` Brian Norris
2015-03-31 6:01 ` Kishon Vijay Abraham I
2015-04-02 2:28 ` Brian Norris
2015-04-07 6:07 ` Kishon Vijay Abraham I
2015-04-07 18:35 ` Brian Norris
2015-03-19 1:23 ` [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY Brian Norris
2015-03-19 11:10 ` Hans de Goede [this message]
2015-03-19 15:53 ` Brian Norris
2015-03-19 17:02 ` Hans de Goede
2015-03-19 17:36 ` Brian Norris
2015-03-19 19:11 ` Brian Norris
2015-03-20 8:48 ` Hans de Goede
2015-03-19 11:33 ` Sergei Shtylyov
2015-03-19 15:58 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550AAEA1.5080301@redhat.com \
--to=hdegoede@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox