From: daniel.lezcano@linaro•org (Daniel Lezcano)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device
Date: Thu, 19 Mar 2015 12:44:27 +0100 [thread overview]
Message-ID: <550AB69B.8000100@linaro.org> (raw)
In-Reply-To: <20150319113824.GC4449@red-moon>
On 03/19/2015 12:38 PM, Lorenzo Pieralisi wrote:
> On Thu, Mar 19, 2015 at 11:27:20AM +0000, Daniel Lezcano wrote:
>
> [...]
>
>>>> for_each_possible_cpu(cpu) {
>>>> ret = arm_cpuidle_init(cpu);
>>>> +
>>>> + /* This cpu does not support any idle states */
>>>> + if (ret == -ENOSYS)
>>>> + continue;
>>>> +
>>>> if (ret) {
>>>> pr_err("CPU %d failed to init idle CPU ops\n", cpu);
>>>> - return ret;
>>>> + goto out_fail;
>>>> + }
>>>> +
>>>> + dev = kzalloc(sizeof(*dev), GFP_KERNEL);
>>>> + if (!dev) {
>>>> + pr_err("Failed to allocate cpuidle device\n");
>>>> + goto out_fail;
>>>> + }
>>>> +
>>>> + dev->cpu = cpu;
>>>> + per_cpu(cpuidle_arm_dev, cpu) = dev;
>>>> +
>>>> + ret = cpuidle_register_device(dev);
>>>> + if (ret) {
>>>> + pr_err("Failed to register cpuidle device for CPU %d\n",
>>>> + cpu);
>>>> + kfree(dev);
>>>> + goto out_fail;
>>>> }
>>>> }
>>>> +out:
>>>> + return ret;
>>>
>>> return 0;
>>>
>>>>
>>>> - return cpuidle_register(drv, NULL);
>>>> +out_fail:
>>>> + for (cpu--; cpu <= 0; cpu--) {
>>>
>>> This loop is wrong.
>>
>> Why is it wrong ? We have to initialize at cpu - 1 to unregister the
>> previous registered cpu, not the current one, no ?
>
> Yes, but on cpu>=0 not cpu<=0
>
> while (--cpu >= 0)
Ah, yes. Thanks for spotting this.
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-03-19 11:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 18:46 [PATCH V2 0/8] ARM: cpuidle: Unify the ARM64/ARM DT approach Daniel Lezcano
2015-03-18 18:46 ` [PATCH V2 1/8] ARM: cpuidle: Remove duplicate header inclusion Daniel Lezcano
2015-03-18 18:46 ` [PATCH V2 2/8] ARM: cpuidle: Add a cpuidle ops structure to be used for DT Daniel Lezcano
2015-03-18 18:46 ` [PATCH V2 3/8] ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function Daniel Lezcano
2015-03-21 20:56 ` Lorenzo Pieralisi
2015-03-18 18:46 ` [PATCH V2 4/8] ARM64: cpuidle: Rename cpu_init_idle to a common function name Daniel Lezcano
2015-03-18 18:46 ` [PATCH V2 5/8] ARM64: cpuidle: Remove arm64 reference Daniel Lezcano
2015-03-18 18:46 ` [PATCH V2 6/8] ARM: cpuidle: Enable the ARM64 driver for both ARM32/ARM64 Daniel Lezcano
2015-03-18 18:46 ` [PATCH V2 7/8] ARM: cpuidle: Register per cpuidle device Daniel Lezcano
2015-03-19 11:08 ` Lorenzo Pieralisi
2015-03-19 11:27 ` Daniel Lezcano
2015-03-19 11:38 ` Lorenzo Pieralisi
2015-03-19 11:44 ` Daniel Lezcano [this message]
2015-03-19 15:31 ` Lina Iyer
2015-03-19 15:33 ` Daniel Lezcano
2015-03-19 15:42 ` Lina Iyer
2015-03-19 17:11 ` Daniel Lezcano
2015-03-18 18:46 ` [PATCH V2 8/8] ARM: cpuidle: Change function name to be consistent with x86 Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550AB69B.8000100@linaro.org \
--to=daniel.lezcano@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox