From: appro@openssl•org (Andy Polyakov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv2] arm: crypto: Add optimized SHA-256/224
Date: Fri, 27 Mar 2015 11:42:55 +0100 [thread overview]
Message-ID: <5515342F.6010703@openssl.org> (raw)
In-Reply-To: <CAKv+Gu_4G69JZJPex_=1xOZ4z5Fxtht4YG4G=TnYrkXPuiXvFg@mail.gmail.com>
>> Could you share the error log please?
>
> OK, I spotted one issue with this code:
>
> arch/arm/crypto/sha256-core.S: Assembler messages:
> arch/arm/crypto/sha256-core.S:1847: Error: invalid constant (ffffefb0)
> after fixup
>
> This is caused by the fact that, when building the integer-only code
> for an older architecture, the conditional compilation produces a
> slightly bigger preceding function, and the symbol K256 is out of
> range for the adr instruction.
>
> @Jean-Christophe: is that the same problem that you hit?
>
> @Andy: I propose we do something similar as in the bsaes code:
>
> #ifdef __thumb__
> #define adrl adr
> #endif
>
> and replace the offending line with
>
> adrl r14,K256
Sorry about delay. Yes, that would do. I did test all combinations, but
all "my" combinations, i.e. without __KERNEL__ defined :-( And without
__KERNEL__ there are few extra instructions in integer-only subroutine
that "push" instruction in question code toward higher address, so that
constant was ffffefc0, which can be encoded. Anyway, I've chosen to add
that #define next to .thumb directive. See attached.
Ard, you have mentioned that you've verified it on big-endian, but I've
spotted little-endian dependency (see #ifndef __ARMEB__ in attached). I
guess that it worked for you either because it was NEON that was tested
(it does work as is) or __LINUX_ARM_ARCH__ was less than 7 (in which
case it uses endian-neutral byte-by-byte data load). Can you confirm either?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sha256-armv4.diff
Type: text/x-patch
Size: 838 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150327/6d108844/attachment.bin>
next prev parent reply other threads:[~2015-03-27 10:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 15:48 [PATCH] arm: crypto: Add NEON optimized SHA-256 Sami Tolvanen
2015-03-16 16:08 ` Ard Biesheuvel
2015-03-16 16:23 ` Sami Tolvanen
2015-03-17 6:56 ` Ard Biesheuvel
2015-03-17 15:09 ` Andy Polyakov
2015-03-17 15:21 ` Sami Tolvanen
2015-03-17 15:51 ` Ard Biesheuvel
2015-03-23 13:50 ` [PATCHv2] arm: crypto: Add optimized SHA-256/224 Sami Tolvanen
2015-03-23 18:26 ` Ard Biesheuvel
2015-03-24 11:35 ` Herbert Xu
2015-03-24 11:40 ` Ard Biesheuvel
2015-03-24 11:46 ` Herbert Xu
2015-03-24 11:57 ` Ard Biesheuvel
2015-03-24 11:32 ` Herbert Xu
2015-03-24 11:33 ` Ard Biesheuvel
2015-03-24 12:27 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-24 12:42 ` Ard Biesheuvel
2015-03-24 13:05 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-24 13:06 ` Ard Biesheuvel
2015-03-24 14:46 ` Ard Biesheuvel
2015-03-24 17:05 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-24 17:40 ` Ard Biesheuvel
2015-03-24 18:17 ` Sami Tolvanen
2015-03-25 6:49 ` Ard Biesheuvel
2015-03-27 10:42 ` Andy Polyakov [this message]
2015-03-27 10:44 ` Ard Biesheuvel
2015-03-27 18:07 ` Ard Biesheuvel
2015-03-29 13:27 ` Andy Polyakov
2015-03-30 8:37 ` [PATCHv3] " Sami Tolvanen
2015-04-01 12:43 ` Herbert Xu
2015-04-01 13:19 ` Sami Tolvanen
2015-04-03 10:04 ` Herbert Xu
2015-03-25 20:00 ` [PATCH] arm: crypto: Add NEON optimized SHA-256 Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5515342F.6010703@openssl.org \
--to=appro@openssl$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox