From: javier.martinez@collabora•co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: exynos5800-peach-pi: suspend/resume (still) broken
Date: Fri, 27 Mar 2015 15:30:34 +0100 [thread overview]
Message-ID: <5515698A.4000708@collabora.co.uk> (raw)
In-Reply-To: <CAM4voanJNJPMdBx5okcVYhqKyzKTctZddvV-XpWzPrA8Og_7oA@mail.gmail.com>
Hello Abhilash,
On 03/27/2015 03:06 PM, Abhilash Kesavan wrote:
> Hello Javier,
>
> On Fri, Mar 27, 2015 at 6:59 PM, Javier Martinez Canillas
> <javier.martinez@collabora•co.uk> wrote:
>> Hello Abhilash,
>>
>> On 03/20/2015 06:40 PM, Abhilash Kesavan wrote:
>>>
>>> Regarding the mdma0 disablement, it looks like for the system to
>>> suspend properly the mdma0 pclk needs to stay on.
>>>
>>
>> I had time today again to work on this issue and the best
>> place I found to enable and disable the mdma0 clock is in
>> exynos5420_pm_{prepare,resume}. Please let me know if you
>> have a better idea of where the clock should be managed.
>>
>
> Modifying exynos5420_clk_suspend in
> drivers/clk/samsung/clk-exynos5420.c would be another way to go,
> however I have not tested if this actually works.
>
Sorry, I just posted the series: "[RFC PATCH 0/2] ARM: EXYNOS: Fix
Suspend-to-RAM on Exynos5420" before reading your email...
Please let me know if you think that is not the best appraoch and
I can come up with another one to modify the clk-exynos5420 suspend
and resume callbacks.
Another option is to use Lee Jone's clocks "always on" support [0]
that has been posted.
>> I'll send a RFC patch-set soon.
>
> Thanks for the effort.
>
Thanks to you for all the help.
> Regards,
> Abhilash
>
Best regards,
Javier
[0]: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-February/326616.html
prev parent reply other threads:[~2015-03-27 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 17:35 exynos5800-peach-pi: suspend/resume (still) broken Kevin Hilman
2015-03-18 10:31 ` Javier Martinez Canillas
2015-03-20 14:23 ` Abhilash Kesavan
2015-03-20 16:16 ` Javier Martinez Canillas
2015-03-20 16:29 ` Abhilash Kesavan
2015-03-20 17:40 ` Abhilash Kesavan
2015-03-20 17:52 ` Javier Martinez Canillas
2015-03-27 13:29 ` Javier Martinez Canillas
2015-03-27 14:06 ` Abhilash Kesavan
2015-03-27 14:30 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5515698A.4000708@collabora.co.uk \
--to=javier.martinez@collabora$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox