From: javier.martinez@collabora•co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] Revert "ARM: dts: add display power domain for exynos5250"
Date: Fri, 27 Mar 2015 15:34:27 +0100 [thread overview]
Message-ID: <55156A73.7060802@collabora.co.uk> (raw)
In-Reply-To: <CAJKOXPewO77pRwh151MFLX+W6WQYPZS759uqjvyZ_TkRf9vmdA@mail.gmail.com>
Hello Krzysztof,
On 03/27/2015 03:29 PM, Krzysztof Kozlowski wrote:
> 2015-03-23 11:49 GMT+01:00 Javier Martinez Canillas
>
> I looked at the DP and FIMD drivers and with great help of Andrzej
> Hajda found the issue: the FIMD driver does not enable DP clock
> (DP_MIE_CLKCON register). The process looks like:
> 1. Bootloader sets the DP_MIE_CLKCON to proper value.
> 2. FIMD is probed, DP power domain is on.
> 3. FIMD is deffered, DP power domain is turned off.
> 4. The FIMD registers are reset so DP clock is turned off.
> 5. DP driver is probed, DP power domain is turned on but clock is not enabled.
>
Great! I knew it was some setup missing that was made by the boot-loader.
> I'll do some more testing and sent a patch for it till end of Monday
> so I think we should not revert this commit.
>
Agree, I of course preferred to fix the actual cause instead of relying
on the boot-loader to do the initialization but I wasn't able to figure
it out so I posted this patch to revert the commit in the meantime.
> Best regards,
> Krzysztof
>
Best regards,
Javier
next prev parent reply other threads:[~2015-03-27 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 10:49 [PATCH 1/1] Revert "ARM: dts: add display power domain for exynos5250" Javier Martinez Canillas
2015-03-27 14:29 ` Krzysztof Kozlowski
2015-03-27 14:34 ` Javier Martinez Canillas [this message]
2015-04-29 17:40 ` Kevin Hilman
2015-04-29 19:45 ` Sjoerd Simons
2015-04-30 0:37 ` Javier Martinez Canillas
2015-04-30 14:59 ` Kevin Hilman
2015-04-30 15:23 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55156A73.7060802@collabora.co.uk \
--to=javier.martinez@collabora$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox