From: andy.yan@rock-chips•com (Andy Yan)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/3] Improve dw-hdmi CTS/N setting
Date: Mon, 30 Mar 2015 21:23:21 +0800 [thread overview]
Message-ID: <55194E49.3000304@rock-chips.com> (raw)
In-Reply-To: <20150327111320.GA4019@n2100.arm.linux.org.uk>
Hi Russell:
On 2015?03?27? 19:13, Russell King - ARM Linux wrote:
> All,
>
> This is a mini-series to try and move audio support for the Designware
> HDMI bridge along.
>
> There are two known versions of the Designware HDMI audio:
>
> - The Rockchip version, which is based upon feeding the HDMI block I2S
> stream(s), which doesn't have any on-board DMA support.
> - The Freescale version, which only has AHB DMA support.
>
> There are two drivers around at present, one which I've had which is
> ALSA based due to its simplicity for the Freescale version of the IP,
> and one which is ASoC based from Yakir Yang for the Rockchip version.
>
> There is some commonality between the two drivers - for example, the
> setup of the CTS/N values is very similar, although not identical.
>
> I have been reviewing (when time permits) the patches from Yakir Yang,
> and making recommendations to try and extract the common parts of the
> driver. This is the patch set I came up with (mentioned in
> 20150202130920.GC8656 at n2100.arm.linux.org.uk).
>
> Yakir merged some of my ideas into his patch set - for example, Yakir
> Yang's "drm: bridge/dw_hdmi: combine hdmi_set_clock_regenerator_n() and
> hdmi_regenerate_cts()" is very close to the version which I came up
> with.
>
> Yakir Yang didn't include the mutex patch, which I've included here -
> it really is necessary because we have potentially two different
> threads which can change the CTS/N values - a change of the video mode
> vs a change in the audio driver.
>
> The last patch is adjusting the CTS/N setting order - I have only gone
> as far as what we know works for iMX6, and this is also identical to
> Yakir Yang's patch.
>
> The identical nature is hardly surprising; my patches were derived from
> a previous set of his patches (which I acknowledge in the commit messages)
> and I detailed in the above message what I wanted to see.
>
> What I would like to see is that - as we are effectively in agreement
> over two of these patches - we get these patches merged rather than
> having to repeatedly see them. If there's any objection, please let me
> know, otherwise I'll collect acks and send them to David.
>
> drivers/gpu/drm/bridge/dw_hdmi.c | 34 +++++++++++++++++++---------------
> 1 file changed, 19 insertions(+), 15 deletions(-)
>
After talk with Yakir Yang, we are glad your suggestion and patch.
Acked-by: Andy Yan <andy.yan@rock-chips•com>
prev parent reply other threads:[~2015-03-30 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 11:13 [PATCH 0/3] Improve dw-hdmi CTS/N setting Russell King - ARM Linux
2015-03-27 11:13 ` [PATCH 1/3] drm: bridge/dw_hdmi: combine hdmi_set_clock_regenerator_n() and hdmi_regenerate_cts() Russell King
2015-03-27 11:13 ` [PATCH 2/3] drm: bridge/dw_hdmi: protect n/cts setting with a mutex Russell King
2015-03-27 11:13 ` [PATCH 3/3] drm: bridge/dw_hdmi: adjust n/cts setting order Russell King
2015-03-30 9:43 ` [PATCH 0/3] Improve dw-hdmi CTS/N setting Philipp Zabel
2015-03-30 12:25 ` Russell King - ARM Linux
2015-03-30 13:23 ` Andy Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55194E49.3000304@rock-chips.com \
--to=andy.yan@rock-chips$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox