From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v1 3/3] phy: cygnus-usbphy: Add Broadcom Cygnus USB phy driver
Date: Tue, 31 Mar 2015 11:46:52 +0530 [thread overview]
Message-ID: <551A3BD4.2040404@ti.com> (raw)
In-Reply-To: <55134D73.7060507@broadcom.com>
Hi,
On Thursday 26 March 2015 05:36 AM, Arun Ramamurthy wrote:
>
>
> On 15-03-25 05:01 PM, Kishon Vijay Abraham I wrote:
>>
>>
>> On Thursday 26 March 2015 04:12 AM, Dmitry Torokhov wrote:
>>> Hi Kishon,
>>>
>>> On Thu, Mar 26, 2015 at 03:58:50AM +0530, Kishon Vijay Abraham I wrote:
>>>> Hi,
>>>>
>>>> On Saturday 21 March 2015 02:55 AM, Arun Ramamurthy wrote:
>>>>> +struct bcm_phy_driver {
>>>>> + void __iomem *usbphy_regs;
>>>>> + void __iomem *usb2h_idm_regs;
>>>>> + void __iomem *usb2d_idm_regs;
>>>>> + struct bcm_phy_instance *ports[MAX_PHY_PORTS];
>>>>
>>>> er.. can't we allocate this dynamically?
>>>
>>> The chip has support for only 3 phys, so I believe allocating array of 3
>>> pointers is simplest.
>>>
>>> [...]
>>>
>>>>> +
>>>>> +static struct phy *bcm_usb_phy_xlate(struct device *dev,
>>>>> + struct of_phandle_args *args)
>>>>> +{
>>>>> + struct bcm_phy_driver *phy_driver = dev_get_drvdata(dev);
>>>>> + struct bcm_phy_instance *port = NULL;
>>>>> + int i;
>>>>> +
>>>>> + if (!phy_driver)
>>>>> + return ERR_PTR(-EINVAL);
>>>>> +
>>>>> + if (WARN_ON(args->args_count != 1))
>>>>> + return ERR_PTR(-EINVAL);
>>>>> +
>>>>> + if (WARN_ON(args->args[0] < 0 || args->args[0] > 1))
>>>>> + return ERR_PTR(-EINVAL);
>>>>> +
>>>>> + for (i = 0; i < ARRAY_SIZE(phy_driver->ports); i++) {
>>>>> + struct bcm_phy_instance *p = phy_driver->ports[i];
>>>>> +
>>>>> + if (p && p->generic_phy->dev.of_node == args->np) {
>>>>> + port = p;
>>>>> + break;
>>>>> + }
>>>>> + }
>>>>> +
>>>>> + if (!port) {
>>>>> + dev_err(dev, "Failed to locate phy %s\n", args->np->name);
>>>>> + return ERR_PTR(-EINVAL);
>>>>> + }
>>>>> +
>>>>> + port->host_mode = args->args[0];
>>>>> +
>>>>> + return port->generic_phy;
>>>>> +}
>>>>
>>>> The xlate function here shouldn't be needed at all. Use of_phy_simple_xlate
>>>> instead.
>>>
>>> of_phy_simple_xlate() will not allow specifying host vs device mode when
>>> requesting phy though...
>>
>> indeed!
>>
> Kishon, to confirm , are the xlate function and the MAX_PHY_PORTS ok or are you
> recommending changes? Thanks
as Dmitry pointed out you'll still need your own implementation of xlate.
Thanks
Kishon
prev parent reply other threads:[~2015-03-31 6:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 21:25 [PATCH v1 0/3] USB PHY driver for Broadcom's Cygnus chipse Arun Ramamurthy
2015-03-20 21:25 ` [PATCH v1 1/3] phy: phy-core: allow specifying supply at port level Arun Ramamurthy
2015-03-20 21:31 ` Dmitry Torokhov
2015-03-25 22:11 ` Kishon Vijay Abraham I
2015-03-25 22:17 ` Dmitry Torokhov
2015-03-25 22:39 ` Kishon Vijay Abraham I
2015-03-25 22:49 ` Dmitry Torokhov
2015-03-25 23:44 ` Kishon Vijay Abraham I
2015-03-25 23:48 ` Dmitry Torokhov
2015-03-20 21:25 ` [PATCH v1 2/3] Phy: DT binding documentation for Broadcom Cygnus USB PHY driver Arun Ramamurthy
2015-03-25 22:16 ` Kishon Vijay Abraham I
2015-03-26 0:04 ` Arun Ramamurthy
2015-03-26 23:02 ` Dmitry Torokhov
2015-03-20 21:25 ` [PATCH v1 3/3] phy: cygnus-usbphy: Add Broadcom Cygnus USB phy driver Arun Ramamurthy
2015-03-25 22:28 ` Kishon Vijay Abraham I
2015-03-25 22:42 ` Dmitry Torokhov
2015-03-26 0:01 ` Kishon Vijay Abraham I
2015-03-26 0:06 ` Arun Ramamurthy
2015-03-31 6:16 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551A3BD4.2040404@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox