From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors
Date: Thu, 09 Apr 2015 12:34:02 +0300 [thread overview]
Message-ID: <5526478A.6060707@cogentembedded.com> (raw)
In-Reply-To: <1428519599-31885-1-git-send-email-computersforpeace@gmail.com>
Hello.
On 4/8/2015 9:59 PM, Brian Norris wrote:
> When working on another SATA driver that uses libahci_platform, I
> noticed an error in this driver; it tries to the the driver data for its
> device, while libata also thinks it can set the driver data. See:
> ahci_platform_init_host()
> -> ata_host_alloc_pinfo()
> -> ata_host_alloc()
> -> dev_set_drvdata()
> So instead of sticking the IP-specific platform data into drvdata, let's
> use the plat_data variable that is reserved for this use.
> Signed-off-by: Brian Norris <computersforpeace@gmail•com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@gmail•com>
> Cc: Maxime Coquelin <maxime.coquelin@st•com>
> Cc: Patrice Chotard <patrice.chotard@st•com>
> ---
> This is ONLY compile tested; I don't have hardware to run. This looks like it
> could have ramifications on suspend/resume support, and hot device removal
> (e.g., sysfs unbind), so it might qualify as -stable, if someone can test it
> drivers/ata/ahci_st.c | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
> diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
> index bc971af262e7..2bd2375c2ab1 100644
> --- a/drivers/ata/ahci_st.c
> +++ b/drivers/ata/ahci_st.c
[...]
> @@ -107,7 +108,9 @@ static void st_ahci_host_stop(struct ata_host *host)
>
> static int st_ahci_probe_resets(struct platform_device *pdev)
> {
> - struct st_ahci_drv_data *drv_data = platform_get_drvdata(pdev);
> + struct ata_host *host = dev_get_drvdata(&pdev->dev);
Why not just platform_get_drvdata()?
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-04-09 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 18:59 [PATCH] ata: ahci_st: fixup layering violations / drvdata errors Brian Norris
2015-04-09 7:18 ` Maxime Coquelin
2015-04-09 9:43 ` Peter Griffin
2015-04-17 14:55 ` Tejun Heo
2015-04-20 13:04 ` Peter Griffin
2015-04-09 9:34 ` Sergei Shtylyov [this message]
2015-04-09 17:27 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5526478A.6060707@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox