Subject: [PATCH v2 05/12] ARM: dts: apq8064: Add SATA controller support.

From: [email-masked] (Srinivas Kandagatla)
Date: Fri, 10 Apr 2015 19:33:45 +0100

On 10/04/15 18:24, Stephen Boyd wrote:
> On 04/10/15 05:34, Srinivas Kandagatla wrote:
>> This patch adds AHCI based SATA controller support to APQ8064.
>> Tested on IFC6410 board.
>>
>> Signed-off-by: Srinivas Kandagatla <[email-masked]>
>> ---
>>   arch/arm/boot/dts/qcom-apq8064-ifc6410.dts |  9 ++++++++
>>   arch/arm/boot/dts/qcom-apq8064.dtsi        | 35 ++++++++++++++++++++++++++++++
>>   2 files changed, 44 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> index 122bf34..c9c9c5e 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> @@ -116,6 +116,15 @@
>>   			};
>>   		};
>>
>> +		sata_phy0: sata-phy at 1b400000{
>
> Space before '{' please.
Yeo, Will fix it in next version.
>
>> +			status = "okay";
>> +		};
>> +
>> +		sata0: sata at 29000000 {
>> +			status		= "okay";
>> +			target-supply	= <&pm8921_s4>;
>> +		};
>> +
>>   		/* OTG */
>>   		usb1_phy: phy at 12500000 {
>>   			status		= "okay";
>> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
>> index 5aac9a5..56cc65e 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
>> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
>> @@ -379,6 +379,41 @@
>>   			usb-phy		= <&usb4_phy>;
>>   		};
>>
>> +		sata_phy0: sata-phy at 1b400000{
>
> Space before '{' please. Also I wonder if it should just be called
> phy at 1b400000 because phy is more standard than sata-phy.
Make sense, I will fix it in next version.