From: Suzuki.Poulose@arm•com (Suzuki K. Poulose)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled
Date: Tue, 21 Apr 2015 10:41:15 +0100 [thread overview]
Message-ID: <55361B3B.3060505@arm.com> (raw)
In-Reply-To: <1429571661-26337-1-git-send-email-tyler.baker@linaro.org>
On 21/04/15 00:14, Tyler Baker wrote:
> The breakpoints test should only should be executed on x86 targets, so lets
> emit a skip and omit the installation when ARCH != x86.
>
> Acked-by: Michael Ellerman <mpe@ellerman•id.au>
> Signed-off-by: Tyler Baker <tyler.baker@linaro•org>
> ---
> tools/testing/selftests/breakpoints/Makefile | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 1822356..430b76d 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64)
> ARCH := x86
> endif
>
> -
> all:
> ifeq ($(ARCH),x86)
> gcc breakpoint_test.c -o breakpoint_test
> @@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test
>
> include ../lib.mk
>
> +install:
> +ifneq ($(ARCH),x86)
> +echo "Not an x86 target, can't install breakpoints selftests"
It would make more sense to send this to stderr than stdout, people may
look for errors there.
Cheers
Suzuki
next prev parent reply other threads:[~2015-04-21 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 23:14 [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled Tyler Baker
2015-04-21 9:41 ` Suzuki K. Poulose [this message]
2015-04-21 22:01 ` Tyler Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55361B3B.3060505@arm.com \
--to=suzuki.poulose@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox