From: jcm@redhat•com (Jon Masters)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v7 1/5] arm64: Enable EDAC on ARM64
Date: Wed, 29 Apr 2015 10:46:51 -0400 [thread overview]
Message-ID: <5540EEDB.9010002@redhat.com> (raw)
In-Reply-To: <20150429144031.GB18867@e104818-lin.cambridge.arm.com>
On 04/29/2015 10:40 AM, Catalin Marinas wrote:
> On Tue, Apr 28, 2015 at 04:10:41PM -0600, Loc Ho wrote:
>> +/*
>> + * ECC atomic, DMA, SMP and interrupt safe scrub function.
>> + * Implements the per arch atomic_scrub() that EDAC use for software
>> + * ECC scrubbing. It reads memory and then writes back the original
>> + * value, allowing the hardware to detect and correct memory errors.
>> + */
>
> The comment here is misleading since the function doesn't do anything.
Well, on the other hand, it is "safe" (joke) ;)
Suggest a documented few line summary of the status from earlier this
year/last year be there instead. Essentially atomic scrubbing is only
safe when you're dealing with a fully coherent system. We captured
various examples of things that could go wrong in the thread link.
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/326986.html
Thanks Loc and team.
Jon.
next prev parent reply other threads:[~2015-04-29 14:46 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 22:10 [PATCH v7 0/4] edac: Add APM X-Gene SoC EDAC driver Loc Ho
2015-04-28 22:10 ` [PATCH v7 1/5] arm64: Enable EDAC on ARM64 Loc Ho
2015-04-28 22:10 ` [PATCH v7 2/5] MAINTAINERS: Add entry for APM X-Gene SoC EDAC driver Loc Ho
2015-04-28 22:10 ` [PATCH v7 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Loc Ho
2015-04-28 22:10 ` [PATCH v7 4/5] edac: Add APM X-Gene SoC EDAC driver Loc Ho
2015-04-28 22:10 ` [PATCH 5/5] arm64: Add APM X-Gene SoC EDAC DTS entries Loc Ho
2015-04-29 8:49 ` [PATCH v7 4/5] edac: Add APM X-Gene SoC EDAC driver Arnd Bergmann
2015-04-29 16:57 ` Rob Herring
2015-04-29 18:23 ` Arnd Bergmann
2015-04-29 17:00 ` Rob Herring
2015-04-29 16:47 ` [PATCH v7 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Rob Herring
2015-04-29 21:33 ` Loc Ho
2015-04-29 21:49 ` Borislav Petkov
2015-04-29 21:56 ` Loc Ho
2015-04-29 22:08 ` Borislav Petkov
2015-04-29 22:20 ` Loc Ho
2015-04-29 23:02 ` Rob Herring
2015-04-30 8:20 ` Borislav Petkov
2015-04-30 8:31 ` Arnd Bergmann
2015-04-30 8:45 ` Borislav Petkov
2015-04-30 9:01 ` Arnd Bergmann
2015-04-30 9:41 ` Borislav Petkov
2015-04-30 10:21 ` Arnd Bergmann
2015-04-30 12:33 ` Borislav Petkov
2015-04-30 12:52 ` Arnd Bergmann
2015-04-30 10:42 ` Arnd Bergmann
2015-04-30 13:00 ` Borislav Petkov
2015-04-30 16:57 ` Loc Ho
2015-04-30 17:18 ` Borislav Petkov
2015-04-30 21:19 ` Loc Ho
2015-04-30 21:30 ` Borislav Petkov
2015-04-30 21:39 ` Loc Ho
2015-04-30 22:36 ` Rob Herring
2015-04-30 22:47 ` Arnd Bergmann
2015-05-01 6:44 ` Loc Ho
2015-04-30 22:59 ` Loc Ho
2015-05-01 19:59 ` Loc Ho
2015-05-04 22:36 ` Rob Herring
2015-05-04 23:39 ` Loc Ho
2015-04-29 22:43 ` Rob Herring
2015-04-30 0:47 ` Loc Ho
2015-04-29 14:40 ` [PATCH v7 1/5] arm64: Enable EDAC on ARM64 Catalin Marinas
2015-04-29 14:46 ` Jon Masters [this message]
2015-04-29 21:39 ` Loc Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5540EEDB.9010002@redhat.com \
--to=jcm@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox