From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] ARM: bcm2835: Add the necessary firmware driver information to the DT
Date: Wed, 29 Apr 2015 17:43:32 -0600 [thread overview]
Message-ID: <55416CA4.6040000@wwwdotorg.org> (raw)
In-Reply-To: <87y4laq4nt.fsf@eliezer.anholt.net>
On 04/29/15 10:29, Eric Anholt wrote:
> Stephen Warren <swarren@wwwdotorg•org> writes:
>
>> On 04/27/2015 05:14 PM, Eric Anholt wrote:
>>> This gets the USB power domain turned on so that DWC2 can probe, even
>>> if the bootloader didn't turn it on for us (which is the case if you
>>> use the RPi firmware without chainloading U-Boot).
>>
>>> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
>>
>>> +&usb {
>>> + power-domains = <&firmware POWER_DOMAIN_USB>;
>>> +};
>>
>> That property doesn't seem to be documented in
>> Documentation/devicetree/bindings/usb/dwc2.txt (which defines compatible
>> = "brcm,bcm2835-usb"). Is it implemented?
>
> power-domains is a generic property that's parsed by
> drivers/base/power/domain.c. See also
> Documentation/devicetree/bindings/power/power_domain.txt&
Sure, but the binding for the node still needs to mention that it's
acceptable for that property to exist (a/k/a that the USB binding
inherits from or aggregates the power domains binding). Part of
mentioning that would be a description of what the entries in the
power-domains property mean (how many are legal, what each index
represents).
prev parent reply other threads:[~2015-04-29 23:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 23:14 [PATCH 0/3] Raspberry Pi firmware driver Eric Anholt
2015-04-27 23:14 ` [PATCH 1/3] dt/bindings: Add binding for the " Eric Anholt
2015-04-28 9:34 ` Lee Jones
2015-04-29 1:42 ` Stephen Warren
2015-04-27 23:14 ` [PATCH 2/3] ARM: bcm2835: Add " Eric Anholt
2015-04-28 7:56 ` Arnd Bergmann
2015-04-28 20:07 ` Eric Anholt
2015-04-28 9:27 ` Lee Jones
2015-04-28 9:28 ` Lee Jones
2015-04-29 1:58 ` Stephen Warren
2015-04-29 2:14 ` Jassi Brar
2015-04-29 2:56 ` Jassi Brar
2015-04-29 17:51 ` Eric Anholt
2015-04-29 23:47 ` Stephen Warren
2015-05-12 17:46 ` Eric Anholt
2015-05-12 22:08 ` Stephen Warren
2015-05-13 0:38 ` Eric Anholt
2015-05-13 18:28 ` Stephen Warren
2015-04-27 23:14 ` [PATCH 3/3] ARM: bcm2835: Add the necessary firmware driver information to the DT Eric Anholt
2015-04-28 9:33 ` Lee Jones
2015-04-29 1:44 ` Stephen Warren
2015-04-29 16:29 ` Eric Anholt
2015-04-29 23:43 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55416CA4.6040000@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox