From: svarbanov@mm-sol•com (Stanimir Varbanov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 2/5] phy: qcom: Add Qualcomm PCIe PHY
Date: Mon, 04 May 2015 18:24:10 +0300 [thread overview]
Message-ID: <55478F1A.3000401@mm-sol.com> (raw)
In-Reply-To: <554783CD.50708@ti.com>
On 05/04/2015 05:35 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Monday 04 May 2015 06:12 PM, Stanimir Varbanov wrote:
>> Add a PCIe PHY driver used by PCIe host controller driver
>> on Qualcomm SoCs like Snapdragon 805.
>>
>> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol•com>
>> ---
>> drivers/phy/Kconfig | 9 ++
>> drivers/phy/Makefile | 1 +
>> drivers/phy/phy-qcom-pcie.c | 291
>> +++++++++++++++++++++++++++++++++++++++++++
>
> Why do you need a new PHY driver for this? Why not use the existing QCOM
> PHY driver. I can see the registers used here in phy-qcom-ufs-qmp-14nm.h?
I agree that on first glance there are similarities, but I'm not sure
does the PHYs are the same IP blocks. Or at least they are different
revisions which have too many differences. So trying to combine them
will lead to more code than now.
Either way I will try to understand how many the differences are.
--
regards,
Stan
next prev parent reply other threads:[~2015-05-04 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 12:42 [PATCH v2 0/5] Qualcomm PCIe and PCIe/PHY drivers Stanimir Varbanov
2015-05-04 12:42 ` [PATCH v2 1/5] DT: phy: qcom: Add PCIe PHY devicetree bindings Stanimir Varbanov
2015-05-04 12:42 ` [PATCH v2 2/5] phy: qcom: Add Qualcomm PCIe PHY Stanimir Varbanov
2015-05-04 14:35 ` Kishon Vijay Abraham I
2015-05-04 15:24 ` Stanimir Varbanov [this message]
2015-05-19 22:41 ` Bjorn Helgaas
2015-05-20 13:08 ` Kishon Vijay Abraham I
2015-05-20 13:23 ` Bjorn Helgaas
2015-05-22 16:25 ` Stanimir Varbanov
2015-05-22 18:06 ` Bjorn Helgaas
2015-05-04 12:42 ` [PATCH v2 3/5] DT: PCI: qcom: Document PCIe devicetree bindings Stanimir Varbanov
2015-05-04 12:42 ` [PATCH v2 4/5] PCI: qcom: Add Qualcomm PCIe controller driver Stanimir Varbanov
2015-11-06 20:50 ` Bjorn Andersson
2015-11-09 16:56 ` Stanimir Varbanov
2015-05-04 12:42 ` [PATCH v2 5/5] ARM: qcom: Add Qualcomm APQ8084 SoC Stanimir Varbanov
2015-05-22 18:22 ` Stephen Boyd
2015-05-22 19:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55478F1A.3000401@mm-sol.com \
--to=svarbanov@mm-sol$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox