From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3 v7] mailbox: Enable BCM2835 mailbox support
Date: Tue, 05 May 2015 13:32:14 -0600 [thread overview]
Message-ID: <55491ABE.40300@wwwdotorg.org> (raw)
In-Reply-To: <CABb+yY2V5dXQ5fH3s2T4-j6-z68bOzaeUN9WQoNze2mc-quD+A@mail.gmail.com>
On 05/04/2015 08:30 PM, Jassi Brar wrote:
> On Tue, May 5, 2015 at 6:27 AM, Eric Anholt <eric@anholt•net> wrote:
>> Jassi Brar <jassisinghbrar@gmail•com> writes:
>>
>>> On Wed, Apr 29, 2015 at 10:39 PM, Eric Anholt <eric@anholt•net> wrote:
>>>
>>>> +
>>>> +struct bcm2835_mbox {
>>>> + struct device *dev;
>>>> + void __iomem *regs;
>>>> + spinlock_t lock;
>>>> + struct mbox_controller controller;
>>>> +};
>>>> +
>>>> +static struct bcm2835_mbox *mbox;
>>>> +
>>>> +static irqreturn_t bcm2835_mbox_irq(int irq, void *dev_id)
>>>> +{
>>>> + struct device *dev = mbox->dev;
>>>> + struct mbox_chan *link = &mbox->controller.chans[0];
>>>> +
>>> I learn from Stephen's other post that the controller could have
>>> multiple channels. In which case this driver is poorly setup. Actually
>>> if the driver was designed properly there isn't anything special to be
>>> done.
>>> Here you choose to waste 'dev_id' and hard-code dereferencing to channel-0
>>
>> There's only the one channel according to the docs. I wish we wouldn't
>> get derailed by speculation on the list when the documentation is
>> available. :(
>>
> Can I have the pointer to the doc please, if its publicly available.
https://www.raspberrypi.org/wp-content/uploads/2012/02/BCM2835-ARM-Peripherals.pdf
next prev parent reply other threads:[~2015-05-05 19:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 22:27 [PATCH 0/3] BCM2835 core mailbox support Eric Anholt
2015-04-27 22:27 ` [PATCH 1/3 v4] dt/bindings: Add binding for the BCM2835 mailbox driver Eric Anholt
2015-04-28 5:21 ` Jassi Brar
2015-04-28 20:44 ` [PATCH 1/3 v5] " Eric Anholt
2015-04-29 1:30 ` Stephen Warren
2015-04-29 16:39 ` Eric Anholt
2015-04-29 23:41 ` Stephen Warren
2015-04-30 4:53 ` Jassi Brar
2015-04-27 22:27 ` [PATCH 2/3 v5] mailbox: Enable BCM2835 mailbox support Eric Anholt
2015-04-28 5:43 ` Jassi Brar
2015-04-28 9:50 ` Lubomir Rintel
2015-04-28 19:49 ` Eric Anholt
2015-04-29 2:07 ` Jassi Brar
2015-04-29 17:05 ` Eric Anholt
2015-04-28 20:54 ` [PATCH 2/3 v6] " Eric Anholt
2015-04-29 1:39 ` Stephen Warren
2015-04-29 17:09 ` [PATCH 2/3 v7] " Eric Anholt
2015-04-30 5:26 ` Jassi Brar
2015-05-01 3:01 ` Stephen Warren
2015-05-05 2:18 ` Jassi Brar
2015-05-05 0:57 ` Eric Anholt
2015-05-05 2:30 ` Jassi Brar
2015-05-05 19:32 ` Stephen Warren [this message]
2015-04-27 22:27 ` [PATCH 3/3] ARM: bcm2835: Add the mailbox to the device tree Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55491ABE.40300@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox