From: rjui@broadcom•com (Ray Jui)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] PCI: iproc: add bcma pcie driver
Date: Tue, 19 May 2015 16:17:22 -0700 [thread overview]
Message-ID: <555BC482.9040902@broadcom.com> (raw)
In-Reply-To: <20150519231456.GX31666@google.com>
On 5/19/2015 4:14 PM, Bjorn Helgaas wrote:
> On Wed, May 13, 2015 at 08:43:47PM +0200, Hauke Mehrtens wrote:
>> On 05/13/2015 06:30 PM, Ray Jui wrote:
>>> Hi Rafal,
>>>
>>> On 5/13/2015 9:19 AM, Rafa? Mi?ecki wrote:
>>>> On 13 May 2015 at 17:56, Ray Jui <rjui@broadcom•com> wrote:
>>>>> On 5/12/2015 11:27 PM, Rafa? Mi?ecki wrote:
>>>>>> On 12 May 2015 at 23:23, Hauke Mehrtens <hauke@hauke-m•de> wrote:
>>>>>>> This driver adds support for the PCIe 2.0 controller found on the bcma
>>>>>>> bus. This controller can be found on (mostly) all Broadcom BCM470X /
>>>>>>> BCM5301X ARM SoCs.
>>>>>>>
>>>>>>> The driver found in the Broadcom SDK does some more stuff, like setting
>>>>>>> up some DMA memory areas, chaining MPS and MRRS to 512 and also some
>>>>>>> PHY changes like "improving" the PCIe jitter and doing some special
>>>>>>> initializations for the 3rd PCIe port.
>>>>>>>
>>>>>>> This was tested on a bcm4708 board with 2 PCIe ports and wireless cards
>>>>>>> connected to them.
>>>>>>>
>>>>>>> PCI_DOMAINS is needed by this driver, because normally there is more
>>>>>>> than one PCIe controller and without PCI_DOMAINS only the first
>>>>>>> controller gets registered.
>>>>>>> This controller gets 6 IRQs, the last one is trigged by all IRQ events.
>>>>>>>
>>>>>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m•de>
>>>>>>
>>>>>> Acked-by: Rafa? Mi?ecki <zajec5@gmail•com>
>>>>>>
>>>>>>
>>>>>>> +static int iproc_pcie_bcma_probe(struct bcma_device *bdev)
>>>>>>> +{
>>>>>>> + struct iproc_pcie *pcie;
>>>>>>> + LIST_HEAD(res);
>>>>>>> + struct resource res_mem;
>>>>>>> + int ret;
>>>>>>> +
>>>>>>> + pcie = devm_kzalloc(&bdev->dev, sizeof(*pcie), GFP_KERNEL);
>>>>>>> + if (!pcie)
>>>>>>> + return -ENOMEM;
>>>>>>> +
>>>>>>> + pcie->dev = &bdev->dev;
>>>>>>> + bcma_set_drvdata(bdev, pcie);
>>>>>>> +
>>>>>>> + pcie->base = bdev->io_addr;
>>>>>>> +
>>>>>>> + res_mem.start = bdev->addr_s[0];
>>>>>>> + res_mem.end = bdev->addr_s[0] + SZ_128M - 1;
>>>>>>> + res_mem.name = "PCIe MEM space";
>>>>>>> + res_mem.flags = IORESOURCE_MEM;
>>>>>>> + pci_add_resource(&res, &res_mem);
>>>>>>> +
>>>>>>> + pcie->resources = &res;
>>>>>>> +
>>>>>>> + pcie->map_irq = iproc_pcie_bcma_map_irq;
>>>>>>> +
>>>>>>> + ret = iproc_pcie_setup(pcie);
>>>>>>
>>>>>> I think I don't like this part of iproc design. It lefts
>>>>>> pcie->resources pointing to some random memory after the setup/probe
>>>>>> are done. Guess it should be a separated parameter or sth.
>>>>>>
>>>>>> The patch is still OK, I just refer to generic iproc possible issue.
>>>>>>
>>>>> Sorry Rafal, but could you please be more specific on this?
>>>>
>>>> iproc_pcie_pltfm_probe (and iproc_pcie_bcma_probe) have local "res"
>>>> variable (each its own). They do:
>>>> pcie->resources = &res;
>>>> and then they call
>>>> iproc_pcie_setup(pcie);
>>>>
>>>> After iproc_pcie_pltfm_probe / iproc_pcie_bcma_probe returns, the
>>>> pointer pcie->resources is not valid anymore, yet pcie struct is still
>>>> in use. Of course pcie->resources isn't used anymore, but still, it's
>>>> some in-struct pointer (to the random memory since local variable is
>>>> not accessible anymore).
>>>>
>>>> I think you should drop
>>>> struct list_head *resources;
>>>> from the struct iproc_pcie and use
>>>> iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *resources)
>>>>
>>>
>>> Okay thanks. That makes sense.
>>>
>>> Or I should keep a copy of the resources under pcie->resources. In the
>>> current pcie-iproc.c, the resource is not used anywhere else except when
>>> creating the root bus under iproc_pcie_setup. But in the future, I might
>>> need to add more code to explicitly program the outbound/inbound windows
>>> so this driver can work with some other iProc SoCs where the desired
>>> windows do not match power-on-reset values.
>>>
>>> I plan to change this along with the window programming patch in the
>>> future. I also think Hauke's current patch is fine.
>>>
>>> Thanks,
>>>
>>> Ray
>>>
>> I think parts of this resources are allocated and never freed.
>>
>> pci_add_resource() allocates some bytes, but I do not see where they are
>> freed, this also applies to the platform driver.
>
> Where are we on this patch? I see Ray's ack for [1/2], and a "I think the
> current patch is fine"; is that an ack for [2/2] as well?
>
> Bjorn
>
Yes, IMO, both patches from Hauke to extend the Iproc PCIe to support
BCMA bus are fine.
Thanks,
Ray
next prev parent reply other threads:[~2015-05-19 23:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 21:22 [PATCH 0/2] PCI: iproc: add bcma PCIe 2.0 controller Hauke Mehrtens
2015-05-12 21:23 ` [PATCH 1/2] PCI: iproc: make of_irq_parse_and_map_pci() configurable Hauke Mehrtens
2015-05-12 22:14 ` Ray Jui
2015-05-12 21:23 ` [PATCH 2/2] PCI: iproc: add bcma pcie driver Hauke Mehrtens
2015-05-12 22:18 ` Ray Jui
2015-05-13 6:27 ` Rafał Miłecki
2015-05-13 15:56 ` Ray Jui
2015-05-13 16:19 ` Rafał Miłecki
2015-05-13 16:30 ` Ray Jui
2015-05-13 18:43 ` Hauke Mehrtens
2015-05-19 23:14 ` Bjorn Helgaas
2015-05-19 23:17 ` Ray Jui [this message]
2015-05-20 5:27 ` Rafał Miłecki
2015-05-12 22:05 ` [PATCH 0/2] PCI: iproc: add bcma PCIe 2.0 controller Ray Jui
2015-05-20 14:52 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555BC482.9040902@broadcom.com \
--to=rjui@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox