From: stefan.wahren@i2se•com (Stefan Wahren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 3/6] power: mxs_power: add driver for mxs power subsystem
Date: Wed, 27 May 2015 18:34:01 +0200 [thread overview]
Message-ID: <5565F1F9.2010801@i2se.com> (raw)
In-Reply-To: <20150527135150.GA9205@earth>
Hi Sebastian,
Am 27.05.2015 um 15:51 schrieb Sebastian Reichel:
> Hi Stefan,
>
> On Wed, May 27, 2015 at 09:12:48AM +0200, Stefan Wahren wrote:
>> Am 23.05.2015 um 19:41 schrieb Sebastian Reichel:
>>> On Wed, Apr 29, 2015 at 10:32:24PM +0000, Stefan Wahren wrote:
>>>> This patch adds a minimal driver for the Freescale i.MX23, i.MX28
>>>> power subsystem. It's required to trigger the probing of the underlying
>>>> drivers like on-chip regulators.
>>> I'm not sure what you need the power supply class for. I see only
>>> one property (ac connected), which is constant. Maybe just drop
>>> the power supply stuff?
>> those SoCs could be powered by 3 different sources:
>> - 5V wall
>> - USB
>> - battery
>>
>> I choose the first one as a base, because it's the simplest one.
>> Unfortunately i don't have the time to implement all of them.
> From what I can see the driver does not implement the 5V wall
> charger handling. It simply assumes, that the 5V wall charger
> is there.
the driver consists of multiple files in the mxs sub directory.
I linked to the main file to reduce search effort. The battery
handling incl. charging should be implemented in ddi_power_battery.c
>From my understanding it's not possible to determine where the 5V
exactly come from (either 5V wall plug or USB). The driver simply uses
the USB PHY state.
>
> While you can skip implementation of battery connection check
> you should make sure, that AC is actually connected.
Do you refer to the right state of property POWER_SUPPLY_PROP_ONLINE or
driver probing?
Stefan
next prev parent reply other threads:[~2015-05-27 16:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 22:32 [PATCH V2 0/6] regulator: enable regulator support for i.MX23/i.MX28 Stefan Wahren
2015-04-29 22:32 ` [PATCH V2 1/6] DT: add binding for mxs power subsystem Stefan Wahren
2015-04-29 22:32 ` [PATCH V2 2/6] ARM: mxs: select syscon for platform Stefan Wahren
2015-04-29 22:32 ` [PATCH V2 3/6] power: mxs_power: add driver for mxs power subsystem Stefan Wahren
2015-05-23 17:41 ` Sebastian Reichel
2015-05-27 7:12 ` Stefan Wahren
2015-05-27 13:51 ` Sebastian Reichel
2015-05-27 16:34 ` Stefan Wahren [this message]
2015-05-28 17:38 ` Sebastian Reichel
2015-04-29 22:32 ` [PATCH V2 4/6] DT: add binding for mxs on-chip regulators Stefan Wahren
2015-05-04 13:51 ` Jürgen Borleis
2015-05-04 20:20 ` Stefan Wahren
2015-05-05 8:21 ` Jürgen Borleis
2015-05-05 17:12 ` Stefan Wahren
2015-04-29 22:32 ` [PATCH V2 5/6] regulator: add mxs on-chip regulator driver Stefan Wahren
2015-05-04 12:36 ` Mark Brown
2015-05-04 20:34 ` Stefan Wahren
2015-05-07 18:37 ` Stefan Wahren
2015-05-07 18:52 ` Mark Brown
2015-05-07 19:25 ` Stefan Wahren
2015-05-07 19:32 ` Mark Brown
2015-05-26 12:16 ` Stefan Wahren
2015-05-27 17:33 ` Mark Brown
2015-05-27 20:58 ` Stefan Wahren
2015-05-28 14:26 ` Mark Brown
2015-04-29 22:32 ` [PATCH V2 6/6] ARM: dts: enable regulator support for i.MX23/i.MX28 Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5565F1F9.2010801@i2se.com \
--to=stefan.wahren@i2se$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox