From: noralf@tronnes•org (Noralf Trønnes)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3 v4] ARM: bcm2835: Add the Raspberry Pi firmware driver
Date: Thu, 28 May 2015 23:39:08 +0200 [thread overview]
Message-ID: <55678AFC.6020404@tronnes.org> (raw)
In-Reply-To: <5567886F.5080108@wwwdotorg.org>
Den 28.05.2015 23:28, skrev Stephen Warren:
> On 05/28/2015 12:33 PM, Eric Anholt wrote:
>> This gives us a function for making mailbox property channel requests
>> of the firmware, which is most notable in that it will let us get and
>> set clock rates.
...
>> +int rpi_firmware_property_list(struct device_node *of_node,
>> + void *data, size_t tag_size)
>> +{
>> + struct platform_device *pdev = of_find_device_by_node(of_node);
> I would expect the of_node -> pdev mapping to happen at client device
> probe time. Simplest for this driver would be if the
> client-probe-time-mapping function returned the "struct rpi_firmware"
> and the client passed that to this function.
What if the firmware driver/device is removed or reloaded?
In that case the client has an invalid pointer. It wouldn't know about
the change.
next prev parent reply other threads:[~2015-05-28 21:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 19:00 RPi firmware driver v2 Eric Anholt
2015-05-13 19:00 ` [PATCH 1/3 v2] dt/bindings: Add binding for the Raspberry Pi firmware driver Eric Anholt
2015-05-14 8:40 ` Lee Jones
2015-05-14 9:57 ` Eric Anholt
2015-05-17 17:11 ` Noralf Trønnes
2015-05-18 17:59 ` [PATCH 1/3 v3] " Eric Anholt
2015-05-28 21:12 ` Stephen Warren
2015-05-13 19:00 ` [PATCH 2/3 v2] ARM: bcm2835: Add " Eric Anholt
2015-05-17 17:30 ` Noralf Trønnes
2015-05-17 18:26 ` Noralf Trønnes
2015-05-18 17:34 ` Eric Anholt
2015-05-18 18:00 ` [PATCH 2/3 v3] " Eric Anholt
[not found] ` <20150528112610.GO11677@x1>
2015-05-28 11:45 ` [PATCH 2/3 v2] " Lee Jones
2015-05-28 18:33 ` [PATCH 2/3 v4] " Eric Anholt
2015-05-28 21:28 ` Stephen Warren
2015-05-28 21:39 ` Noralf Trønnes [this message]
2015-05-28 22:09 ` Stephen Warren
2015-05-28 22:36 ` Eric Anholt
2015-05-28 21:42 ` Noralf Trønnes
2015-05-28 22:10 ` Stephen Warren
2015-05-28 22:38 ` Eric Anholt
2015-05-28 22:43 ` Noralf Trønnes
2015-05-28 21:17 ` [PATCH 2/3 v2] " Stephen Warren
2015-05-28 22:40 ` Noralf Trønnes
2015-05-13 19:00 ` [PATCH 3/3 v2] ARM: bcm2835: Add the firmware driver information to the RPi DT Eric Anholt
2015-05-28 21:29 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55678AFC.6020404@tronnes.org \
--to=noralf@tronnes$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox