From: dinguyen@opensource•altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv5 1/2] ARM: socfpga: support suspend to ram
Date: Thu, 28 May 2015 22:15:16 -0500 [thread overview]
Message-ID: <5567D9C4.7090903@opensource.altera.com> (raw)
In-Reply-To: <1432847977-18880-2-git-send-email-atull@opensource.altera.com>
On 5/28/15 4:19 PM, Alan Tull wrote:
> Add code that requests that the sdr controller go into
> self-refresh mode. This code is run from ocram.
>
> Suspend-to-RAM and EDAC support are mutually exclusive on
> SOCFPGA. If the EDAC is enabled, it will prevent the
> platform from going into suspend.
>
> Example of how to request to suspend to ram:
> $ echo enabled > \
> /sys/devices/soc/ffc02000.serial0/tty/ttyS0/power/wakeup
>
> $ echo -n mem > /sys/power/state
>
> Signed-off-by: Alan Tull <atull@opensource•altera.com>
> Cc: Pavel Machek <pavel@denx•de>
> Cc: Arnd Bergmann <arnd@arndb•de>
> Cc: Dinh Nguyen <dinguyen@opensource•altera.com>
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix•de>
> ---
> v2: use Generic on-chip SRAM driver to allocate ocram
> rm fncpy_align since generic allocator handles alignment
> check __arm_ioremap_exec return code
> check for NULL pointers
> add a comment regarding sdram controller configuration
> v3: fix renamed #define
> propagate socfpga_setup_ocram_self_refresh error code
> v4: Kconfig: don't need to select GENERIC_ALLOCATER
> add CONFIG_SOCFPGA_SUSPEND
> make s2r and EDAC support mutually exclusive
> socfpga.c: add sdr_ctl_base_addr
> return error if ocram not available in device tree
> update copyright years
> v5: remove compile time dependency
> edac driver will prevent suspend
> don't configure scu standby mode; done in enable_scu().
> fix comments about required sdram controller configuration
> ---
> arch/arm/mach-socfpga/Kconfig | 10 ++-
> arch/arm/mach-socfpga/Makefile | 1 +
> arch/arm/mach-socfpga/core.h | 6 +-
> arch/arm/mach-socfpga/pm.c | 149 ++++++++++++++++++++++++++++++++++
> arch/arm/mach-socfpga/self-refresh.S | 136 +++++++++++++++++++++++++++++++
> arch/arm/mach-socfpga/socfpga.c | 6 +-
> drivers/edac/altera_edac.c | 20 +++++
> 7 files changed, 325 insertions(+), 3 deletions(-)
> create mode 100644 arch/arm/mach-socfpga/pm.c
> create mode 100644 arch/arm/mach-socfpga/self-refresh.S
>
Which branch are you basing this patch on? I got a trivial patch
conflict in Kconfig when I applied to arm-soc/for-next and v4.1-rc5.
Also, I'm getting these sparse warnings:
arch/arm/mach-socfpga/pm.c:86:25: warning: incorrect type in argument 1
(different address spaces)
arch/arm/mach-socfpga/pm.c:86:25: expected void *<noident>
arch/arm/mach-socfpga/pm.c:86:25: got void [noderef]
<asn:2>*[assigned] suspend_ocram_base
arch/arm/mach-socfpga/pm.c:108:52: warning: cast removes address space
of expression
Dinh
next prev parent reply other threads:[~2015-05-29 3:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 21:19 [PATCHv5 0/2] socfpga: support suspend to ram Alan Tull
2015-05-28 21:19 ` [PATCHv5 1/2] ARM: " Alan Tull
2015-05-29 3:15 ` Dinh Nguyen [this message]
2015-05-29 15:54 ` atull
2015-05-29 20:55 ` atull
2015-05-28 21:19 ` [PATCHv5 2/2] ARM: socfpga: dts: add sdram controller dt binding doc Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5567D9C4.7090903@opensource.altera.com \
--to=dinguyen@opensource$(echo .)altera.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox