From: majun258@huawei•com (majun (F))
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4]:Add mbigen driver to support mbigen interrupt controller
Date: Sat, 30 May 2015 14:10:08 +0800 [thread overview]
Message-ID: <55695440.4050509@huawei.com> (raw)
In-Reply-To: <1432964283.2984.9.camel@perches.com>
Hi Joe Perches:
Thanks for you advice.
I will fixed it in next version
? 2015/5/30 13:38, Joe Perches ??:
> On Sat, 2015-05-30 at 11:19 +0800, majun (F) wrote:
>> This patch contains the mbigen device driver.
>
> Trivial notes:
>
> Please use scripts/checkpatch.pl on your patches and see
> if you want to correct any of the messages it produces.
>
>> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
>
> You could add
> #define pr_fmt(fmt) "mbigen: " fmt
> before any of the #includes so that all of the
> pr_<level>(fmt, ...) uses are prefixed with "mbigen: "
>
>> +int mbi_parse_irqs(struct device *dev, struct mbi_ops *ops)
>> +{
>> + pr_warn("%s:this function not use now\n", __func__);
>
> Maybe pr_warn_once()
>
>> + return -EINVAL;
>> +}
>> +EXPORT_SYMBOL(mbi_parse_irqs);
>> +
>> +void mbi_free_irqs(struct device *dev, unsigned int virq, unsigned int nvec)
>> +{
>> + pr_warn("%s:this function not use now\n", __func__);
>
> pr_warn_once()?
>
>> +static struct mbigen *mbigen_get_device(struct mbigen_chip *chip,
>> + unsigned int nid)
>> +{
>> + struct mbigen *tmp, *mbigen;
>> + bool found = false;
>> +
>> + if (nid >= MG_NR) {
>> + pr_warn("MBIGEN: Device ID exceeds max number!\n");
>
> So this wouldn't need a "MBIGEN: " prefix
>
> etc...
>
>
> .
>
next prev parent reply other threads:[~2015-05-30 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 3:19 [PATCH 1/4]:Add mbigen driver to support mbigen interrupt controller majun (F)
2015-05-30 5:38 ` Joe Perches
2015-05-30 6:10 ` majun (F) [this message]
2015-06-01 8:50 ` Marc Zyngier
2015-06-01 9:05 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55695440.4050509@huawei.com \
--to=majun258@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox