From: guohanjun@huawei•com (Hanjun Guo)
To: linux-arm-kernel@lists•infradead.org
Subject: [Patch v3 6/7] x86/PCI/ACPI: Use common interface to support PCI host bridge
Date: Tue, 2 Jun 2015 14:29:53 +0800 [thread overview]
Message-ID: <556D4D61.8080509@huawei.com> (raw)
In-Reply-To: <556D45A3.9070708@linux.intel.com>
On 2015/6/2 13:56, Jiang Liu wrote:
> On 2015/5/22 21:55, Hanjun Guo wrote:
>> On 2015?05?14? 16:56, Jiang Liu wrote:
>>> Use common interface to simplify ACPI PCI host bridge implementation.
>>>
>>> Signed-off-by: Jiang Liu <jiang.liu@linux•intel.com>
>>> ---
>>> arch/x86/pci/acpi.c | 292
>>> +++++++++++++++------------------------------------
>>> 1 file changed, 85 insertions(+), 207 deletions(-)
>>>
>> [...]
>>> -static void release_pci_root_info(struct pci_host_bridge *bridge)
>>> +static void pci_acpi_root_release_info(struct acpi_pci_root_info *ci)
>>> {
>>> - struct resource *res;
>>> - struct resource_entry *entry;
>>> - struct pci_root_info *info = bridge->release_data;
>>> -
>>> - resource_list_for_each_entry(entry, &bridge->windows) {
>>> - res = entry->res;
>>> - if (res->parent &&
>>> - (res->flags & (IORESOURCE_MEM | IORESOURCE_IO)))
>>> - release_resource(res);
>>> - }
>>> -
>>> - teardown_mcfg_map(info);
>>> - kfree(info);
>>> + teardown_mcfg_map(ci);
>>> + kfree(ci);
>> Implicit pointer cast? I think add a comment here that %p of ci
>> is same as %p of info would be helpful for review and easy understood.
> Good point, will change as:
> kfree(container_of(ci, struct pci_root_info, common));
This way is better :)
Thanks
Hanjun
next prev parent reply other threads:[~2015-06-02 6:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 8:56 [Patch v3 0/7] Consolidate ACPI PCI root common code into ACPI core Jiang Liu
2015-05-14 8:56 ` [Patch v3 1/7] ACPI/PCI: Enhance ACPI core to support sparse IO space Jiang Liu
2015-05-22 13:35 ` Hanjun Guo
2015-05-14 8:56 ` [Patch v3 2/7] ia64/PCI/ACPI: Use common ACPI resource parsing interface for host bridge Jiang Liu
2015-05-22 13:42 ` Hanjun Guo
2015-05-14 8:56 ` [Patch v3 3/7] ia64/PCI: Use common struct resource_entry to replace struct iospace_resource Jiang Liu
2015-05-22 13:46 ` Hanjun Guo
2015-05-14 8:56 ` [Patch v3 4/7] x86/PCI: Rename struct pci_sysdata as struct pci_controller Jiang Liu
2015-05-14 8:56 ` [Patch v3 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core Jiang Liu
2015-05-18 13:08 ` Hanjun Guo
2015-05-20 3:16 ` Jiang Liu
2015-05-20 3:33 ` Hanjun Guo
2015-05-22 11:23 ` Hanjun Guo
2015-05-22 13:49 ` Hanjun Guo
2015-05-14 8:56 ` [Patch v3 6/7] x86/PCI/ACPI: Use common interface to support PCI host bridge Jiang Liu
2015-05-22 13:55 ` Hanjun Guo
2015-06-02 5:56 ` Jiang Liu
2015-06-02 6:29 ` Hanjun Guo [this message]
2015-05-14 8:56 ` [Patch v3 7/7] ia64/PCI/ACPI: " Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556D4D61.8080509@huawei.com \
--to=guohanjun@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox