From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu
Date: Wed, 03 Jun 2015 08:55:55 +0900 [thread overview]
Message-ID: <556E428B.8070008@samsung.com> (raw)
In-Reply-To: <556DB1E2.5080607@suse.de>
On 02.06.2015 22:38, Andreas F?rber wrote:
> Am 02.06.2015 um 22:02 schrieb Krzysztof Kozlowski:
>> W dniu 16.03.2015 o 07:00, Andreas F?rber pisze:
>>> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel•com>
>>> Signed-off-by: Andreas F?rber <afaerber@suse•de>
>>> ---
>>> v2 -> v3: Unchanged
>>>
>>> v1 -> v2:
>>> * Filled in Sob from Hakjoo Kim
>>>
>>> arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++
>>> 1 file changed, 25 insertions(+)
>>
>> What is the rationale behind doing this in separate patch, not as part
>> of 2/5? You can just add new board DTS with all of its features at once,
>> but maybe I am missing something?
>
> This patch depends on the pinctrl driver, 2/5 on nothing.
>
> By keeping it a separate patch it was intended to go in more quickly
> (clear fail there ;)) and it's easier to review the actual changes -
> squashing is always easier than picking apart.
OK, I'm fine with it.
The patch looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
Can you resend everything with the change in chosen/console?
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-06-02 23:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 22:00 [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
2015-03-15 22:00 ` [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation Andreas Färber
2015-03-16 7:24 ` Javier Martinez Canillas
2015-06-02 12:58 ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree Andreas Färber
2015-03-16 7:56 ` Javier Martinez Canillas
2015-03-16 10:27 ` Andreas Färber
2015-03-16 10:58 ` Javier Martinez Canillas
2015-03-17 2:10 ` Kukjin Kim
2015-06-02 12:43 ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 3/5] pinctrl: exynos: add exynos5410 SoC specific data Andreas Färber
2015-03-23 17:22 ` Tomasz Figa
2015-06-02 12:46 ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 4/5] ARM: dts: add pinctrl support to Exynos5410 Andreas Färber
2015-06-02 12:59 ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu Andreas Färber
2015-03-16 8:02 ` Javier Martinez Canillas
2015-06-02 13:02 ` Krzysztof Kozlowski
2015-06-02 13:38 ` Andreas Färber
2015-06-02 23:55 ` Krzysztof Kozlowski [this message]
2015-03-31 19:48 ` [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556E428B.8070008@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox