From: javier.martinez@collabora•co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: multi_v7_defconfig: enable usb3503
Date: Thu, 04 Jun 2015 08:38:24 +0200 [thread overview]
Message-ID: <556FF260.5060006@collabora.co.uk> (raw)
In-Reply-To: <7hsia846wa.fsf@deeprootsystems.com>
Hello Kevin,
On 06/04/2015 03:08 AM, Kevin Hilman wrote:
> riku.voipio at linaro.org writes:
>
>> From: Riku Voipio <riku.voipio@linaro•org>
>>
>> CONFIG_USB_HSIC_USB3503 is needed by exynos5250-arndale for the on-board
>> asix network controller. Enable it so networking works with
>> multi_v7_defconfig out of box like it does with exynos_defconfig.
>>
>> USB3503 is also referenced from exynos4412-odroidu3.dts and
>> exynos5250-spring.dts so this patch should improve
>> multi_v7_defconfig on those platforms as well.
>>
>> Signed-off-by: Riku Voipio <riku.voipio@linaro•org>
>
> Tyler pointed me to this in order to get arndale networking on mainline,
> but looks like this might need to be revisited for current mainline.
>
> I tested this and it doesn't work because as of commit 7de7c6717f2c
> (ARM: multi_v7_defconfig: Enable Exynos USB PHY) the PHY that this
> depends on is built as a module in multi_v7_config, so having this
> driver built-in doesn't help. Even after the PHY driver is loaded, this
> driver will not detect the hardware.
>
> So instead, I think this driver should be built as a module as well.
> Testing that, I can get networking by doing loading both the phy and
> this driver after boot:
>
> # modprobe phy-exynos-usb2
> # modprobe usb3503
>
Current policy is to have as much as possible built as a module
in multi_v7_config so regardless of your issue I think that the
patch should be re-spun to change this.
But I wonder why is not working, shouldn't the driver defer and
be probed again once the PHY driver probe succeeds?
> Kevin
>
Best regards,
Javier
next prev parent reply other threads:[~2015-06-04 6:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 13:54 [PATCH] ARM: multi_v7_defconfig: enable usb3503 riku.voipio at linaro.org
2015-06-04 1:08 ` Kevin Hilman
2015-06-04 6:38 ` Javier Martinez Canillas [this message]
2015-06-04 17:47 ` Kevin Hilman
2015-06-05 12:45 ` Arnd Bergmann
2015-09-14 8:35 ` Riku Voipio
2015-09-15 6:50 ` Krzysztof Kozlowski
2015-09-15 8:17 ` Sjoerd Simons
2015-09-15 8:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556FF260.5060006@collabora.co.uk \
--to=javier.martinez@collabora$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox