From: sboyd@codeaurora•org (Stephen Boyd)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] arm64: perf: Don't use of_node after putting it
Date: Fri, 05 Jun 2015 11:53:09 -0700 [thread overview]
Message-ID: <5571F015.9080109@codeaurora.org> (raw)
In-Reply-To: <20150605144539.GC7420@arm.com>
On 06/05/2015 07:45 AM, Will Deacon wrote:
> On Wed, Jun 03, 2015 at 09:53:37PM +0100, Stephen Boyd wrote:
>> arch/arm64/kernel/perf_event.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
>> index 702591f6180a..8af7784a8e35 100644
>> --- a/arch/arm64/kernel/perf_event.c
>> +++ b/arch/arm64/kernel/perf_event.c
>> @@ -1340,12 +1340,13 @@ static int armpmu_device_probe(struct platform_device *pdev)
>> if (arch_find_n_match_cpu_physical_id(dn, cpu, NULL))
>> break;
>>
>> - of_node_put(dn);
>> if (cpu >= nr_cpu_ids) {
>> pr_warn("Failed to find logical CPU for %s\n",
>> dn->name);
>> + of_node_put(dn);
>> break;
>> }
>> + of_node_put(dn);
>>
>> irqs[i] = cpu;
>> }
> Yeah, I agree this needs changing but given (a) the CPU node isn't going
> to disappear and (b) this patch will conflict horribly with my queue for
> 4.2, do you mind if I sit on this until after the merge window (as a fix
> for 4.2)?
>
>
Sure, no problem.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-06-05 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 20:53 [PATCH 1/2] arm64: perf: Don't use of_node after putting it Stephen Boyd
2015-06-03 20:53 ` [PATCH 2/2] arm: " Stephen Boyd
2015-06-05 14:45 ` [PATCH 1/2] arm64: " Will Deacon
2015-06-05 18:53 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5571F015.9080109@codeaurora.org \
--to=sboyd@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox