From: Nathan_Lynch@mentor•com (Nathan Lynch)
To: linux-arm-kernel@lists•infradead.org
Subject: build failure with VDSO on non-glibc based systems
Date: Tue, 23 Jun 2015 10:16:15 -0500 [thread overview]
Message-ID: <5589783F.6040605@mentor.com> (raw)
In-Reply-To: <55893659.80607@arm.com>
On 06/23/2015 05:35 AM, Szabolcs Nagy wrote:
> if the host toolchain is not glibc based then the arm kernel build fails with
>
> arch/arm/vdso/vdsomunge.c:53:19: fatal error: error.h: No such file or directory
>
> error.h is a glibc only header (ie not available in musl, newlib and bsd libcs).
Thanks for the report and the patch. I agree it is inappropriate to
unnecessarily depend on glibc features in host programs.
> i attached a patch that fixes the build failure for me.
A few issues with the patch prevent me from accepting it as-is.
The patch lacks the required Signed-off-by: line; see part 11 in
Documentation/SubmittingPatches.
The body of your email would suffice as the commit log; please include
it in the patch itself.
>
> +#define fail(...) ( \
> + failed = 1, \
> + fprintf(stderr, "%s: ", argv0), \
> + fprintf(stderr, __VA_ARGS__), \
> + exit(EXIT_FAILURE))
> +
It would be more in keeping with Linux coding style to write this as a
do { ... } while (0) block (Chapter 12 of Documentation/CodingStyle).
Writing it as a function, if possible, would be best.
Please attend to these issues and resubmit. Alternatively, I have a
musl installation I can test with and develop an equivalent fix
(crediting you with the initial report, of course).
prev parent reply other threads:[~2015-06-23 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 10:35 build failure with VDSO on non-glibc based systems Szabolcs Nagy
2015-06-23 15:16 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5589783F.6040605@mentor.com \
--to=nathan_lynch@mentor$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox