From: vitalya@ti•com (Vitaly Andrianov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] keystone: psci: adds cpu_die implementation
Date: Thu, 25 Jun 2015 12:55:40 -0400 [thread overview]
Message-ID: <558C328C.5070803@ti.com> (raw)
In-Reply-To: <20150625161308.GF6844@leverpostej>
On 06/25/2015 12:13 PM, Mark Rutland wrote:
> On Thu, Jun 25, 2015 at 05:01:36PM +0100, Vitaly Andrianov wrote:
>>
>>
>> On 06/25/2015 10:59 AM, santosh shilimkar wrote:
>>> On 6/25/2015 7:45 AM, Mark Rutland wrote:
>>>> Hi,
>>>>
>>>> On Thu, Jun 25, 2015 at 03:02:50PM +0100, Vitaly Andrianov wrote:
>>>>> This commit add cpu_die implementation using psci api
>>>>
>>>> I don't understand. If you have a PSCI implementation, it should be
>>>> sufficient to have a PSCI node (and enable-method) in your DT, and the
>>>> generic code will be used. Nothing should be required in your board
>>>> code.
>>>>
>>>> You should also use CPU_ON to bring secondaries online rather than
>>>> mixing up PSCI and platform-specific mechanisms.
>>>>
>>> Good point about CPU_ON. We need that as well.
>>>
>> Does it mean that keystone_defconfig must always have CONFIG_HOTPLUG_CPU
>> and CONFIG_ARM_PSCI enabled?
>
> No.
>
> You need CONFIG_ARM_PSCI for PSCI CPU_ON. Without CONFIG_HOTPLUG_CPU,
> you'll get PSCI CPU_ON but not PSCI CPU_OFF.
>
>> What is if someone doesn't want to have HOTPLUG_CPU?
>
> Then you don't get PSCI CPU_OFF, but can still have PSCI CPU_ON.
>
> Only the portions of the PSCI code required for turning CPUs off are
> dependent on HOTPLUG_CPU.
>
>> How he can boot secondary CPU w/o platform-specific mechanizm?
>
> By using PSCI CPU_ON.
>
> Thanks,
> Mark
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Thanks Mark,
I need rework and re-test the patch.
One more question. Shall I post the dts related commit, which add PSCI
command together with this commit? Or it may be posted later independently?
Thanks,
Vitaly
next prev parent reply other threads:[~2015-06-25 16:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 14:02 [PATCH] keystone: psci: adds cpu_die implementation Vitaly Andrianov
2015-06-25 14:45 ` Mark Rutland
2015-06-25 14:59 ` santosh shilimkar
2015-06-25 16:01 ` Vitaly Andrianov
2015-06-25 16:13 ` Mark Rutland
2015-06-25 16:55 ` Vitaly Andrianov [this message]
2015-06-25 16:57 ` Mark Rutland
2015-06-25 17:20 ` Mark Rutland
2015-06-25 18:42 ` santosh shilimkar
2015-06-26 16:57 ` Vitaly Andrianov
2015-06-26 16:59 ` Mark Rutland
2015-06-26 17:47 ` Grygorii Strashko
2015-06-26 18:06 ` Vitaly Andrianov
2015-06-26 18:41 ` santosh shilimkar
2015-06-25 14:54 ` santosh shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558C328C.5070803@ti.com \
--to=vitalya@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox