From: gangchen@rdamicro•com (Chen Gang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] ARM : missing corrupted reg in __do_div_asm
Date: Sun, 28 Jun 2015 19:29:06 +0800 [thread overview]
Message-ID: <558FDA82.4070308@rdamicro.com> (raw)
In-Reply-To: <20150609130948.GD7557@n2100.arm.linux.org.uk>
Hi, Russell
I have uploaded V2 of the patch based on your comments on Jun-19. Hope
you can review that again.
Br, Chen Gang
On 06/09/2015 09:09 PM, Russell King - ARM Linux wrote:
> On Tue, Jun 02, 2015 at 02:13:29PM +0800, Chen Gang wrote:
>> __xl (r0 in little endian system, or R1 in big endian system) is corrupted
>> after calling __do_div64 and compiler is not informed about this in
>> macro __do_div_asm. If n is used again afterwards, __xl won't be
>> reloaded and n will contain incorrect value.
>> ---
> This commit message needs improving. Please either upper case both r0
> and r1 in the first line, or lower case them both. Secondly, the Linux
> kernel has a requirement that all contributions are signed-off. Please
> read Documentation/SubmittingPatches for information, particularly
> section 11.
>
> Other than that, the patch looks fine, thanks.
>
>> arch/arm/include/asm/div64.h | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/div64.h b/arch/arm/include/asm/div64.h
>> index 662c7bd..fa9489e 100644
>> --- a/arch/arm/include/asm/div64.h
>> +++ b/arch/arm/include/asm/div64.h
>> @@ -34,12 +34,14 @@
>> register unsigned long long __n asm("r0") = n; \
>> register unsigned long long __res asm("r2"); \
>> register unsigned int __rem asm(__xh); \
>> + register unsigned int __clobber asm(__xl); \
>> asm( __asmeq("%0", __xh) \
>> - __asmeq("%1", "r2") \
>> - __asmeq("%2", "r0") \
>> - __asmeq("%3", "r4") \
>> + __asmeq("%1", __xl) \
>> + __asmeq("%2", "r2") \
>> + __asmeq("%3", "r0") \
>> + __asmeq("%4", "r4") \
>> "bl __do_div64" \
>> - : "=r" (__rem), "=r" (__res) \
>> + : "=r" (__rem), "=r" (__clobber), "=r" (__res) \
>> : "r" (__n), "r" (__base) \
>> : "ip", "lr", "cc"); \
>> n = __res; \
>> --
>> 1.9.1
>>
>>
next prev parent reply other threads:[~2015-06-28 11:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] </home/gachen/Re: [PATCH 1_1] ARM:r0 is also corrupted after calling __do_div64..eml>
2015-06-02 6:13 ` [PATCH 1/1] ARM : missing corrupted reg in __do_div_asm Chen Gang
2015-06-08 5:30 ` Chen Gang
2015-06-09 13:09 ` Russell King - ARM Linux
2015-06-19 11:28 ` [PATCH v2 " Chen Gang
2015-06-28 11:29 ` Chen Gang [this message]
2016-03-28 4:19 [PATCH " Chen Gang
2016-03-29 10:19 ` Arnd Bergmann
2016-03-29 10:26 ` Dave Martin
2016-03-29 10:34 ` Russell King - ARM Linux
2016-03-29 10:56 ` Dave Martin
2016-03-30 3:27 ` 陈刚(Gangchen)
2016-03-30 14:07 ` Dave Martin
2016-03-31 7:56 ` 陈刚(Gangchen)
2016-03-31 10:30 ` Dave Martin
2016-03-31 11:20 ` 陈刚(Gangchen)
2016-03-31 11:41 ` Dave Martin
2016-03-29 10:58 ` 陈刚(Gangchen)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558FDA82.4070308@rdamicro.com \
--to=gangchen@rdamicro$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox