From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 2/2] ARM: dts: add buffalo linkstation ls-wvl/vl
Date: Mon, 29 Jun 2015 15:52:09 +0200 [thread overview]
Message-ID: <55914D89.2010208@free-electrons.com> (raw)
In-Reply-To: <20150629134343.GB4535@lunn.ch>
Hi Andrew, Roger,
On 29/06/2015 15:43, Andrew Lunn wrote:
> On Mon, Jun 29, 2015 at 03:22:56PM +0200, Gregory CLEMENT wrote:
>> Hi Roger,
>>
>> On 22/06/2015 17:02, Roger Shimizu wrote:
>>> Add dts file to support Buffalo Linkstation LS-WVL and LS-VL,
>>> which are 3.5" HDD NAS in 2-bay and 1-bay respectively.
>>>
>>> Signed-off-by: Roger Shimizu <rogershimizu@gmail•com>
>>> Reviewed-by: Nobuhiro Iwamatsu <iwamatsu@nigauri•org>
>>
>> it seems that you addressed Andrew's remarks too, so
>>
>> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>>
>>
>> However I will wait for Andrew's formal acked-by before applying it.
>
> Hi Gregory
>
> One minor nit pick. Maybe you can fix it while committing?
>
>>> + pmx_led_alarm: pmx-led-alarm {
>>> + marvell,pins = "mpp36";
>>> + marvell,function = "gpio";
>>> + };
>>> + pmx_led_function_red: pmx-led-function_red {
>
> Second _red should be -red.
OK I will take care of it.
Roger, you wont have to send a new version for fixing it.
Thanks,
Gregory
>
>>> + marvell,pins = "mpp37";
>>> + marvell,function = "gpio";
>>> + };
>
> Other than that,
>
> Acked-by: Andrew Lunn <andrew@lunn•ch>
>
> Thanks
> Andrew
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-06-29 13:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 11:28 [PATCH 0/2] ARM: dts: add buffalo linkstation ls-wxl/wsxl & ls-wvl/vl Roger Shimizu
2015-06-19 11:28 ` [PATCH 1/2] ARM: dts: add buffalo linkstation ls-wxl/wsxl Roger Shimizu
2015-06-19 22:14 ` Andrew Lunn
2015-06-20 12:36 ` Roger Shimizu
2015-06-20 14:51 ` Andrew Lunn
2015-06-20 15:56 ` Roger Shimizu
2015-06-20 16:03 ` Andrew Lunn
2015-06-21 15:16 ` Roger Shimizu
2015-06-21 20:09 ` Andrew Lunn
2015-06-22 15:00 ` [PATCH v2 " Roger Shimizu
2015-06-29 13:22 ` Gregory CLEMENT
2015-06-29 13:38 ` Andrew Lunn
2015-07-09 13:12 ` Gregory CLEMENT
2015-07-09 14:06 ` Roger Shimizu
2015-06-19 11:28 ` [PATCH 2/2] ARM: dts: add buffalo linkstation ls-wvl/vl Roger Shimizu
2015-06-19 22:22 ` Andrew Lunn
2015-06-22 15:02 ` [PATCH v2 " Roger Shimizu
2015-06-29 13:22 ` Gregory CLEMENT
2015-06-29 13:43 ` Andrew Lunn
2015-06-29 13:52 ` Gregory CLEMENT [this message]
2015-07-09 13:13 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55914D89.2010208@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox