From: r.baldyga@hackerion•com (Robert Baldyga)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit()
Date: Tue, 07 Jul 2015 18:24:30 +0200 [thread overview]
Message-ID: <559BFD3E.6040609@hackerion.com> (raw)
In-Reply-To: <20150707150156.GE4341@mwanda>
On 07/07/2015 05:01 PM, Dan Carpenter wrote:
> On Tue, Jul 07, 2015 at 04:02:51PM +0200, Robert Baldyga wrote:
>> Should use usb_ep_set_maxpacket_limit instead of setting
>> maxpacket value manually.
>>
>
> This is a behavior change, right, since now we're setting
> ep->ep.maxpacket and ep->ep.maxpacket_limit where before we only set
> the first. I don't understand. This patch description is not clear.
Since maxpacket_limit was introduced all UDC drivers should set it, as
it is used by epautoconf. The ep.maxpacket_limit contains actual maximum
maxpacket value supported by hardware, ep.maxpacket is set only for
backward compatibility. Hence setting maxpacket manually instead of
using usb_ep_set_maxpacket_limit() is actually a bug.
I will add better description to commit message.
>
>> Signed-off-by: Robert Baldyga <r.baldyga@samsung•com>
>> ---
>> drivers/usb/isp1760/isp1760-udc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c
>> index 18ebf5b1..3699962 100644
>> --- a/drivers/usb/isp1760/isp1760-udc.c
>> +++ b/drivers/usb/isp1760/isp1760-udc.c
>> @@ -1382,11 +1382,11 @@ static void isp1760_udc_init_eps(struct isp1760_udc *udc)
>> * This fits in the 8kB FIFO without double-buffering.
>> */
>> if (ep_num == 0) {
>> - ep->ep.maxpacket = 64;
>> + usb_ep_set_maxpacket_limit(&ep->ep, 64);
>> ep->maxpacket = 64;
>> udc->gadget.ep0 = &ep->ep;
>> } else {
>> - ep->ep.maxpacket = 512;
>> + usb_ep_set_maxpacket_limit(&ep->ep, 512);
>> ep->maxpacket = 0;
>> list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
>> }
Thanks,
Robert Baldyga
next prev parent reply other threads:[~2015-07-07 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 14:02 [PATCH 0/5] usb: gadget: miscellaneous fixes Robert Baldyga
2015-07-07 14:02 ` [PATCH 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails Robert Baldyga
2015-07-07 14:53 ` Dan Carpenter
2015-07-07 16:00 ` Robert Baldyga
2015-07-08 7:55 ` Dan Carpenter
2015-07-07 14:02 ` [PATCH 2/5] usb: gadget: midi: avoid redundant f_midi_set_alt() call Robert Baldyga
2015-07-07 14:02 ` [PATCH 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit() Robert Baldyga
2015-07-07 15:01 ` Dan Carpenter
2015-07-07 16:24 ` Robert Baldyga [this message]
2015-07-07 14:02 ` [PATCH 4/5] staging: emxx_udc: " Robert Baldyga
2015-07-07 14:10 ` Sergei Shtylyov
2015-07-07 15:03 ` Dan Carpenter
2015-07-07 14:02 ` [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check Robert Baldyga
2015-07-08 8:20 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559BFD3E.6040609@hackerion.com \
--to=r.baldyga@hackerion$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox