Subject: [PATCH v2 2/2] ARM: dts: add buffalo linkstation ls-wvl/vl

From: [email-masked] (Gregory CLEMENT)
Date: Thu, 09 Jul 2015 15:13:58 +0200

Hi Andrew, Roger,

On 29/06/2015 15:43, Andrew Lunn wrote:
> On Mon, Jun 29, 2015 at 03:22:56PM +0200, Gregory CLEMENT wrote:
>> Hi Roger,
>>
>> On 22/06/2015 17:02, Roger Shimizu wrote:
>>> Add dts file to support Buffalo Linkstation LS-WVL and LS-VL,
>>> which are 3.5" HDD NAS in 2-bay and 1-bay respectively.
>>>
>>> Signed-off-by: Roger Shimizu <[email-masked]>
>>> Reviewed-by: Nobuhiro Iwamatsu <[email-masked]>
>>
>> it seems that you addressed Andrew's remarks too, so
>>
>> Acked-by: Gregory CLEMENT <[email-masked]>
>>
>>
>> However I will wait for Andrew's formal acked-by before applying it.
> 
> Hi Gregory
> 
> One minor nit pick. Maybe you can fix it while committing?
> 
>>> +			pmx_led_alarm: pmx-led-alarm {
>>> +				marvell,pins = "mpp36";
>>> +				marvell,function = "gpio";
>>> +			};
>>> +			pmx_led_function_red: pmx-led-function_red {
> 
> Second _red should be -red.
> 
>>> +				marvell,pins = "mpp37";
>>> +				marvell,function = "gpio";
>>> +			};
> 
> Other than that,
> 
> Acked-by: Andrew Lunn <[email-masked]>

Now applied on mvebu/dt with the typo fixed

Thanks,

Gregory

> 	  Thanks
> 		Andrew

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com