From: f.fainelli@gmail•com (Florian Fainelli)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: BCM63xx: fix parameter to of_get_cpu_node in bcm63138_smp_boot_secondary
Date: Fri, 10 Jul 2015 11:19:40 -0700 [thread overview]
Message-ID: <55A00CBC.1050706@gmail.com> (raw)
In-Reply-To: <1436549771-6097-1-git-send-email-sudeep.holla@arm.com>
On 10/07/15 10:36, Sudeep Holla wrote:
> of_get_cpu_node provides the device node associated with the given
> logical CPU and cpu_logical_map contains the physical id for each CPU
> in the logical ordering. Passing cpu_logical_map(cpu) to of_get_cpu_node
> is incorrect.
>
> This patch fixes the issue by passing the logical CPU number to
> of_get_cpu_node
>
> Cc: Florian Fainelli <f.fainelli@gmail•com>
> Cc: bcm-kernel-feedback-list at broadcom.com
> Signed-off-by: Sudeep Holla <sudeep.holla@arm•com>
Tested-by: Florian Fainelli <f.fainelli@gmail•com>
Acked-by: Florian Fainelli <f.fainelli@gmail•com>
> ---
> arch/arm/mach-bcm/bcm63xx_smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi,
>
> I found this accidentally when searching for cpu_logical_map. It's
> clearly a bug, it seem to be working fine as the physical and the
> logical CPU ordering is same most of the time.
Good catch! Kevin, Arnd, Olof, if you have any "late late" fixes for
4.2-rcX, can you pick this one directly?
Thanks!
>
> Regards,
> Sudeep
>
> diff --git a/arch/arm/mach-bcm/bcm63xx_smp.c b/arch/arm/mach-bcm/bcm63xx_smp.c
> index 3f014f18cea5..b8e18cc8f237 100644
> --- a/arch/arm/mach-bcm/bcm63xx_smp.c
> +++ b/arch/arm/mach-bcm/bcm63xx_smp.c
> @@ -127,7 +127,7 @@ static int bcm63138_smp_boot_secondary(unsigned int cpu,
> }
>
> /* Locate the secondary CPU node */
> - dn = of_get_cpu_node(cpu_logical_map(cpu), NULL);
> + dn = of_get_cpu_node(cpu, NULL);
> if (!dn) {
> pr_err("SMP: failed to locate secondary CPU%d node\n", cpu);
> ret = -ENODEV;
>
--
Florian
next prev parent reply other threads:[~2015-07-10 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 17:36 [PATCH] ARM: BCM63xx: fix parameter to of_get_cpu_node in bcm63138_smp_boot_secondary Sudeep Holla
2015-07-10 18:19 ` Florian Fainelli [this message]
2015-07-12 1:35 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A00CBC.1050706@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox