From: cyrille.pitchen@atmel•com (Cyrille Pitchen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 6/7] Documentation: atmel-quadspi: add binding file for Atmel QSPI driver
Date: Mon, 20 Jul 2015 10:54:05 +0200 [thread overview]
Message-ID: <55ACB72D.60506@atmel.com> (raw)
In-Reply-To: <55A8EAAE.6010506@cogentembedded.com>
Hi Sergei,
thanks for the review. For the next series I've removed all references to
"qspi" in the node example but the one from the compatible string.
I've also removed the leading 0 in the size of the second memory region.
Best Regards,
Cyrille
Le 17/07/2015 13:44, Sergei Shtylyov a ?crit :
> Hello.
>
> On 7/16/2015 6:27 PM, Cyrille Pitchen wrote:
>
>> This patch documents the DT bindings for the driver of the Atmel QSPI
>> controller embedded inside sama5d2x SoCs.
>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel•com>
>> ---
>> .../devicetree/bindings/mtd/atmel-quadspi.txt | 29 ++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mtd/atmel-quadspi.txt
>
>> diff --git a/Documentation/devicetree/bindings/mtd/atmel-quadspi.txt b/Documentation/devicetree/bindings/mtd/atmel-quadspi.txt
>> new file mode 100644
>> index 000000000000..a0d60ac7ae10
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mtd/atmel-quadspi.txt
>> @@ -0,0 +1,29 @@
>> +* Atmel Quad Serial Peripheral Interface (QSPI)
>> +
>> +Required properties:
>> + - compatible : Should be "atmel,sama5d2-qspi"
>> + - reg : the first contains the register location and length,
>> + the second contains the memory mapping address and length
>> + - interrupts : Should contain the interrupt for the device
>> + - clocks : The clock needed by the QSPI controller
>> + - #address-cells : should be 1
>> + - #size-cells : should be 0
>> +
>> +Example:
>> +
>> +qspi0: qspi at f0020000 {
>
> Once again, the ePAPR standard tells up to call the node just "spi", not "qspi".
>
>> + compatible = "atmel,sama5d2-qspi";
>> + reg = <0xf0020000 0x100>,
>> + <0xd0000000 0x08000000>;
>
> Either you use the leading zeroes or you don't. :-)
>
> [...]
>
> MBR, Sergei
>
next prev parent reply other threads:[~2015-07-20 8:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 15:27 [PATCH 0/7] add driver for Atmel QSPI controller Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 1/7] Documentation: mtd: add a DT property to set the number of dummy cycles Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 2/7] mtd: spi-nor: notify (Q)SPI controller about protocol change Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 3/7] mtd: spi-nor: allow to tune the number of dummy cycles Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 4/7] Documentation: mtd: add a DT property to set the latency code of Spansion memory Cyrille Pitchen
2015-07-16 17:44 ` Marek Vasut
2015-07-20 9:23 ` Cyrille Pitchen
2015-07-20 19:29 ` Marek Vasut
2015-07-16 15:27 ` [PATCH 5/7] mtd: spi-nor: allow the set the latency code on Spansion memories Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 6/7] Documentation: atmel-quadspi: add binding file for Atmel QSPI driver Cyrille Pitchen
2015-07-17 11:44 ` Sergei Shtylyov
2015-07-20 8:54 ` Cyrille Pitchen [this message]
2015-07-16 15:27 ` [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller Cyrille Pitchen
2015-07-17 9:04 ` Paul Bolle
2015-07-20 8:55 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ACB72D.60506@atmel.com \
--to=cyrille.pitchen@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox