public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: sboyd@codeaurora•org (Stephen Boyd)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 07/10] opp: Add OPP sharing information to OPP library
Date: Mon, 20 Jul 2015 10:46:27 -0700	[thread overview]
Message-ID: <55AD33F3.4000302@codeaurora.org> (raw)
In-Reply-To: <20150718063304.GD11802@linux>

On 07/17/2015 11:33 PM, Viresh Kumar wrote:
> From: Viresh Kumar <viresh.kumar@linaro•org>
> Date: Wed, 11 Feb 2015 16:16:28 +0800
> Subject: [PATCH] opp: Add OPP sharing information to OPP library
>
> An opp can be shared by multiple devices, for example its very common
> for CPUs to share the OPPs, i.e. when they share clock/voltage rails.
>
> This patch adds support of shared OPPs to the OPP library.
>
> Instead of a single device, dev_opp will not contain a list of devices
> that use it. It also senses if the device (we are trying to initialize
> OPPs for) shares OPPs with a device added earlier and in that case we
> update the list of devices managed by OPPs instead of duplicating OPPs
> again.
>
> The same infrastructure will be used for the old OPP bindings, with
> later patches.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro•org>

Reviewed-by: Stephen Boyd <sboyd@codeaurora•org>

> +static struct device_opp *_managed_opp(const struct device_node *np)
> +{
> +	struct device_opp *dev_opp;
> +
> +	list_for_each_entry_rcu(dev_opp, &dev_opp_list, node)
> +		if (dev_opp->np == np) {
> +			/*
> +			 * Multiple devices can point to the same OPP table and
> +			 * so will have same node-pointer, np.
> +			 *
> +			 * But the OPPs will be considered as shared only if the
> +			 * OPP table contains a "opp-shared" property.
> +			 */
> +			if (dev_opp->shared_opp)
> +				return dev_opp;
> +			else
> +				return NULL;
> +		

The janitors will probably find this and say that it could be simplified 
to an if () and a return without the else.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-07-20 17:46 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 11:57 [PATCH 00/10] OPP: Add code to support operating-points-v2 bindings Viresh Kumar
2015-06-15 11:57 ` [PATCH 01/10] opp: Relocate few routines Viresh Kumar
2015-07-02  1:25   ` Stephen Boyd
2015-07-24 17:08   ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 02/10] OPP: Create _remove_device_opp() for freeing dev_opp Viresh Kumar
2015-07-02  1:25   ` Stephen Boyd
2015-07-24 17:13   ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 03/10] OPP: Allocate dev_opp from _add_device_opp() Viresh Kumar
2015-07-02  1:02   ` Stephen Boyd
2015-07-02  6:24     ` Viresh Kumar
2015-07-02 23:46       ` Stephen Boyd
2015-07-03  6:45         ` Viresh Kumar
2015-07-06 22:31           ` Stephen Boyd
2015-07-24 17:25           ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 04/10] OPP: Break _opp_add_dynamic() into smaller functions Viresh Kumar
2015-07-24 17:42   ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 05/10] opp: Add support to parse "operating-points-v2" bindings Viresh Kumar
2015-07-02  1:13   ` Stephen Boyd
2015-07-02  6:38     ` Viresh Kumar
2015-07-02 16:07       ` Stephen Boyd
2015-07-03  6:08         ` Viresh Kumar
2015-07-08 13:41   ` Bartlomiej Zolnierkiewicz
2015-07-09  5:18     ` Viresh Kumar
2015-07-24 18:02       ` Bartlomiej Zolnierkiewicz
2015-07-27  3:14         ` Viresh Kumar
2015-07-27  3:02     ` Viresh Kumar
2015-07-28 23:03       ` Stephen Boyd
2015-07-29  6:53         ` Viresh Kumar
2015-07-30 10:17         ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 06/10] OPP: Add clock-latency-ns support Viresh Kumar
2015-07-02  1:27   ` Stephen Boyd
2015-06-15 11:57 ` [PATCH 07/10] opp: Add OPP sharing information to OPP library Viresh Kumar
2015-07-17 22:51   ` Stephen Boyd
2015-07-18  6:33     ` Viresh Kumar
2015-07-20 17:46       ` Stephen Boyd [this message]
2015-07-21  2:18         ` Viresh Kumar
2015-07-27  3:20         ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 08/10] OPP: Add support for opp-suspend Viresh Kumar
2015-07-17 19:22   ` Stephen Boyd
2015-07-18  6:32     ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 09/10] opp: Add helpers for initializing CPU OPPs Viresh Kumar
2015-06-15 11:57 ` [PATCH 10/10] cpufreq-dt: Add support for operating-points-v2 bindings Viresh Kumar
2015-07-09 16:13   ` Bartlomiej Zolnierkiewicz
2015-07-09 16:44     ` Bartlomiej Zolnierkiewicz
2015-07-15  2:59     ` Viresh Kumar
2015-06-30 16:44 ` [PATCH 00/10] OPP: Add code to support " Viresh Kumar
2015-07-17  2:36   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AD33F3.4000302@codeaurora.org \
    --to=sboyd@codeaurora$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox