From: jic23@kernel•org (Jonathan Cameron)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings
Date: Mon, 20 Jul 2015 18:54:25 +0100 [thread overview]
Message-ID: <55AD35D1.7000607@kernel.org> (raw)
In-Reply-To: <CAFeBWL6ARBReHq8jom3kGu3iOaPib41nOJ3-gx358nYwsGKLfw@mail.gmail.com>
On 20/07/15 18:47, Adam Lee wrote:
> Hello, here is some more context from the TPS65950's TRM [1].
>
> Quoting from section 15.3.1.2.1 VUSB3V1 section:
>
> "VUSB3V1 is also used to bias analog multiplexers on the four MCPC
> pins between the carkit and the MADC (supplied by VINTANA2)."
>
>
> And from section 15.4.11. MADC Monitoring Using MCPC:
>
> "Four MCPC pins can be selected as analog conversion input pins by
> setting the CARKIT_ANA_CTRL[3] SEL_MADC_MCPC bit."
>
> My patch addresses both (set the register, and enable 3v1). And yes it
> has been tested on Gumstix Overo COMs (OMAP3 + TPS65950).
>
> Hope to hear from IIO maintainers!
I dug the patch out of the archives.
Looks clear enough to me. Could you resend the patch with linux-iio cc'd?
I will want an Ack from Sebastian.
Thanks,
Jonathan
>
> [1] http://www.droid-developers.org/images/2/21/Tps65950_TRM.pdf
>
> On Fri, Jul 17, 2015 at 2:42 AM, Peter Meerwald <pmeerw@pmeerw•net> wrote:
>> Hello,
>>
>> adding linux-iio...
>>
>>> To get a chance of this patch being considered for inclusion, you
>>> should send this to the maintainers of the phy and iio framework.
>>> There is a high chance, that none of them will see your mail.
>>>
>>> On Thu, Jul 16, 2015 at 03:20:27PM -0700, Adam YH Lee wrote:
>>>> MADC[3:6] reads incorrect values without these two following changes:
>>>
>>> uhm MADC[3:6] are externally available analog inputs. Your
>>> change will result in them being tied to the USB module.
>>
>> change regarding TWL4030_USB_SEL_MADC_MCPC is necessary at
>> least for some hardware revisions to get proper ADC values
>>
>>>> - enable the 3v1 bias regulator for ADC[3:6]
>>>
>>> The regulator is not required for correct MADC functionality, but
>>> for correct USB measureing. The regulator should not be requested
>>> by the madc module, but by the usb module, which is connected to
>>> the madc.
>>
>> in my experience, the MADC exhibits several strange things, I wouldn't be
>> surprised that this bias is somehow necessary for operation even if it is
>> not what the spec says -- has this been tested?
>>
>>>> - configure ADC[3:6] lines as input, not as USB
>>>
>>> I don't think that should be done for all boards.
>>>
>>>> [...]
>>>
>>> -- Sebastian
>>>
>>
>> --
>>
>> Peter Meerwald
>> +43-664-2444418 (mobile)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-07-20 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 22:20 [PATCH] Fix incomplete initialization of ADC[3:6] Adam YH Lee
2015-07-16 22:20 ` [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings Adam YH Lee
2015-07-17 9:00 ` Sebastian Reichel
2015-07-17 9:42 ` Peter Meerwald
2015-07-20 17:47 ` Adam Lee
2015-07-20 17:54 ` Jonathan Cameron [this message]
2015-07-20 18:23 ` Adam Lee
-- strict thread matches above, loose matches on Subject: below --
2015-07-20 18:14 [PATCH] Fix incomplete initialization of ADC[3:6]$ Adam YH Lee
2015-07-20 18:14 ` [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings Adam YH Lee
2015-07-20 18:54 ` Peter Meerwald
2015-07-20 19:19 ` Adam Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD35D1.7000607@kernel.org \
--to=jic23@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox