From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 2/4] irqchip: bcm2835: If a parent interrupt is registered, chain from it.
Date: Tue, 21 Jul 2015 20:08:29 -0600 [thread overview]
Message-ID: <55AEFB1D.6090108@wwwdotorg.org> (raw)
In-Reply-To: <1436837718-956-3-git-send-email-eric@anholt.net>
On 07/13/2015 07:35 PM, Eric Anholt wrote:
> The BCM2836 (Raspberry Pi 2) uses two levels of interrupt handling
> with the CPU-local interrupts being the root, so we need to register
> ours as chained off of the CPU's local interrupt.
Sorry for the slow review; laziness after vacation!
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
> +The BCM2836 contains the same interrupt controller with the same
> +interrupts, but the per-CPU interrupt controller is the root, and an
> +interrupt there indicates that the ARMCTRL has an interrupt to handle.
> +
> Required properties:
>
> - compatible : should be "brcm,bcm2835-armctrl-ic"
Since there are some differences between the bcm2835 and bcm2836 HW
blocks, I'd expect the compatible value to be different for each. In
particular...
> +Optional properties:
> +- interrupt-parent : Specifies the parent interrupt controller when this
> + controller is the second level.
> +- interrupts : Specifies the interrupt on the parent for this interrupt
> + controller to handle.
I'd classify that as "additional required properties for
brcm,bcm2836-armctrl-ic"
... and with different compatible values for the two chips, you would
know when probe() should require vs. reject the property.
next prev parent reply other threads:[~2015-07-22 2:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 1:35 Raspberry Pi 2 interrupt controller support (v2) Second round Eric Anholt
2015-07-14 1:35 ` [PATCH v2 1/4] irqchip: bcm2835: Refactor handle_IRQ() calls out of MAKE_HWIRQ Eric Anholt
2015-07-14 1:35 ` [PATCH v2 2/4] irqchip: bcm2835: If a parent interrupt is registered, chain from it Eric Anholt
2015-07-22 2:08 ` Stephen Warren [this message]
2015-07-22 18:17 ` Eric Anholt
2015-07-24 4:13 ` Stephen Warren
2015-07-14 1:35 ` [PATCH v2 3/4] irqchip: Add documentation for the bcm2836 interrupt controller Eric Anholt
2015-07-14 1:35 ` [PATCH v2 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2 Eric Anholt
2015-07-22 2:09 ` Stephen Warren
2015-07-22 18:02 ` Eric Anholt
2015-07-26 9:52 ` Thomas Gleixner
2015-07-27 18:42 ` [PATCH] irq-bcm2836: Move SMP boot to the irqchip code Eric Anholt
2015-07-27 18:46 ` Florian Fainelli
2015-07-27 20:09 ` [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs Eric Anholt
2015-08-02 10:22 ` Thomas Gleixner
2015-08-03 23:23 ` Eric Anholt
2015-08-04 7:14 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AEFB1D.6090108@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox