From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage
Date: Sat, 25 Jul 2015 15:34:03 +0200 [thread overview]
Message-ID: <55B3904B.3050408@free-electrons.com> (raw)
In-Reply-To: <1436711211-18223-7-git-send-email-robh@kernel.org>
Hi Rob,
On 12/07/2015 16:26, Rob Herring wrote:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
>
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
>
> Signed-off-by: Rob Herring <robh@kernel•org>
> Cc: Thomas Gleixner <tglx@linutronix•de>
> Cc: Jason Cooper <jason@lakedaemon•net>
> Cc: Kukjin Kim <kgene@kernel•org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung•com>
> Cc: Stephen Warren <swarren@wwwdotorg•org>
> Cc: Lee Jones <lee@kernel•org>
> Cc: Alexander Shiyan <shc_work@mail•ru>
> Cc: Maxime Ripard <maxime.ripard@free-electrons•com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: linux-rpi-kernel at lists.infradead.org
> ---
> v2:
> - Fix build error on clps711x
>
[...]
> diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
> index 0d3b0fe..b8bf8b0 100644
> --- a/drivers/irqchip/irq-armada-370-xp.c
> +++ b/drivers/irqchip/irq-armada-370-xp.c
> @@ -201,7 +201,6 @@ static int armada_370_xp_msi_map(struct irq_domain *domain, unsigned int virq,
> {
> irq_set_chip_and_handler(virq, &armada_370_xp_msi_irq_chip,
> handle_simple_irq);
> - set_irq_flags(virq, IRQF_VALID);
OK
>
> return 0;
> }
> @@ -318,7 +317,7 @@ static int armada_370_xp_mpic_irq_map(struct irq_domain *h,
> irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip,
> handle_level_irq);
> }
> - set_irq_flags(virq, IRQF_VALID | IRQF_PROBE);
> + irq_set_noprobe(virq);
I think it should be irq_set_probe(virq), I don't see why you inverted the probe flag.
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-07-25 13:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 14:26 [PATCH v2 00/13] Kill off set_irq_flags Rob Herring
2015-07-12 14:26 ` [PATCH v2 01/13] ARM: kill off set_irq_flags usage Rob Herring
2015-07-13 3:19 ` Shawn Guo
2015-07-14 21:14 ` Robert Jarzmik
2015-07-12 14:26 ` [PATCH v2 02/13] clk: " Rob Herring
2015-07-12 14:26 ` [PATCH v2 03/13] dma: " Rob Herring
2015-07-12 14:26 ` [PATCH v2 04/13] gpio: " Rob Herring
2015-07-12 14:26 ` [PATCH v2 05/13] gpu/drm: " Rob Herring
2015-07-12 14:26 ` [PATCH v2 06/13] irqchip: " Rob Herring
2015-07-12 16:43 ` Thomas Gleixner
2015-07-13 16:26 ` Rob Herring
2015-07-16 11:10 ` Thomas Gleixner
2015-07-16 13:26 ` Russell King - ARM Linux
2015-07-16 19:32 ` Robert Jarzmik
2015-07-16 20:34 ` Russell King - ARM Linux
2015-07-25 13:34 ` Gregory CLEMENT [this message]
2015-07-27 18:39 ` Rob Herring
2015-07-12 14:26 ` [PATCH v2 07/13] memory: " Rob Herring
2015-08-13 7:51 ` Tony Lindgren
2015-07-12 14:26 ` [PATCH v2 08/13] mfd: " Rob Herring
2015-07-12 14:26 ` [PATCH v2 09/13] PCI: " Rob Herring
2015-07-12 14:34 ` Jingoo Han
2015-07-12 14:26 ` [PATCH v2 10/13] pinctrl: " Rob Herring
2015-07-12 15:45 ` Tomasz Figa
2015-07-12 14:26 ` [PATCH v2 11/13] sh: " Rob Herring
2015-07-12 14:26 ` [PATCH v2 12/13] ARM: remove ununsed set_irq_flags Rob Herring
2015-07-12 14:26 ` [PATCH v2 13/13] arm64: " Rob Herring
2015-07-12 16:49 ` [PATCH v2 00/13] Kill off set_irq_flags Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B3904B.3050408@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox