From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow
Date: Tue, 28 Jul 2015 09:36:58 +0900 [thread overview]
Message-ID: <55B6CEAA.7050904@samsung.com> (raw)
In-Reply-To: <CABxcv=kHgvXgVSzLj=bABqO26r3w7T7ezAUfdh0n4S_N3ZM-Mw@mail.gmail.com>
On 28.07.2015 06:24, Javier Martinez Canillas wrote:
> Hello Michal,
>
> The patch looks good to me, just one small comment below.
>
> On Mon, Jul 27, 2015 at 10:11 PM, Michal Suchanek <hramrach@gmail•com> wrote:
>> Although there is only one choice of chipselect it is necessary to
>> specify it. The driver cannot claim the gpio otherwise.
>>
>> Signed-off-by: Michal Suchanek <hramrach@gmail•com>
>>
>> --
>> v2
>> - don't move unrelated line
>> ---
>> arch/arm/boot/dts/exynos5250-snow.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index b7f4122..62be08a 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -688,6 +688,7 @@
>> status = "okay";
>> samsung,spi-src-clk = <0>;
>> num-cs = <1>;
>> + cs-gpios = <&gpa2 5 0>;
>
> NIT: this should be GPIO_ACTIVE_HIGH instead of 0 but maybe Kukjin or
> Krzysztof can fixup when applying it?
>
>> };
>>
>> &usbdrd_dwc3 {
>> --
>
> Acked-by: Javier Martinez Canillas <javier@osg•samsung.com>
Yes, the GPIO_ACTIVE_HIGH would be better. Can you re-spin the patch
with this change and respective Acks? Including mine ack:
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-07-28 0:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 20:11 [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow Michal Suchanek
2015-07-27 21:24 ` Javier Martinez Canillas
2015-07-28 0:36 ` Krzysztof Kozlowski [this message]
2015-07-28 8:45 ` [PATCH v3] " Michal Suchanek
2015-07-29 0:57 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B6CEAA.7050904@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox