From: michal.simek@xilinx•com (Michal Simek)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFCv2 1/3] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.
Date: Tue, 28 Jul 2015 10:25:08 +0200 [thread overview]
Message-ID: <55B73C64.5050903@xilinx.com> (raw)
In-Reply-To: <1438070702.3193.4.camel@pengutronix.de>
On 07/28/2015 10:05 AM, Philipp Zabel wrote:
> Am Freitag, den 24.07.2015, 17:21 -0700 schrieb Moritz Fischer:
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus•com>
>> ---
>> Documentation/devicetree/bindings/reset/zynq-reset-pl.txt | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
>>
>> diff --git a/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
>> new file mode 100644
>> index 0000000..ac4499e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
>> @@ -0,0 +1,13 @@
>> +Xilinx Zynq PL Reset Manager
>> +
>> +Required properties:
>> +- compatible: "xlnx,zynq-reset-pl"
>> +- syscon <&slcr>;
>> +- #reset-cells: 1
>> +
>> +Example:
>> + rstc: rstc at 240 {
>> + #reset-cells = <1>;
>> + compatible = "xlnx,zynq-reset-pl";
>> + syscon = <&slcr>;
>
> Why the syscon phandle if rstc always is the child of slcr? Why not just
> request the syscon for the rstc's parent node.
We are using this description for pincntrl which was properly reviewed
that's why I expect Moritz just use the same style.
But yes also referencing parent should work.
TBH I don't have strong preference but having unified style is something
what I would prefer.
Also I see that using parent is used by others and it looks like that
having something like syscon_regmap_lookup_parent will be worth to have.
Thanks,
Michal
next prev parent reply other threads:[~2015-07-28 8:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 0:21 [RFCv2 0/3] Adding support for Zynq Reset Controller Moritz Fischer
2015-07-25 0:21 ` [RFCv2 1/3] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings Moritz Fischer
2015-07-27 5:09 ` Michal Simek
2015-07-28 4:55 ` Moritz Fischer
2015-07-28 5:41 ` Michal Simek
2015-07-28 2:58 ` Sören Brinkmann
2015-07-28 4:52 ` Moritz Fischer
2015-07-28 22:53 ` Sören Brinkmann
2015-07-29 6:14 ` Moritz Fischer
2015-07-29 17:38 ` Sören Brinkmann
2015-07-30 14:37 ` Michal Simek
2015-07-28 8:05 ` Philipp Zabel
2015-07-28 8:25 ` Michal Simek [this message]
2015-07-28 13:57 ` Moritz Fischer
2015-07-28 15:16 ` Philipp Zabel
2015-07-25 0:21 ` [RFCv2 2/3] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller Moritz Fischer
2015-07-27 6:56 ` Michal Simek
2015-07-28 5:03 ` Moritz Fischer
2015-07-28 5:42 ` Michal Simek
2015-07-28 6:59 ` Nicolas Ferre
2015-07-28 7:44 ` Michal Simek
2015-07-28 13:54 ` Moritz Fischer
2015-07-25 0:21 ` [RFCv2 3/3] reset: reset-zynq: Adding support " Moritz Fischer
2015-07-27 5:14 ` Michal Simek
2015-07-27 7:12 ` Michal Simek
2015-07-28 4:59 ` Moritz Fischer
2015-07-28 5:43 ` Michal Simek
2015-07-28 8:38 ` Philipp Zabel
2015-07-28 14:05 ` Moritz Fischer
2015-07-28 14:27 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B73C64.5050903@xilinx.com \
--to=michal.simek@xilinx$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox