From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: dts: Add support for phyCORE-AM335x SoM
Date: Tue, 28 Jul 2015 11:29:33 +0300 [thread overview]
Message-ID: <55B73D6D.2040801@compulab.co.il> (raw)
In-Reply-To: <20150727143444.GD15004@beef>
Hi Matt,
On 07/27/15 17:34, Matt Porter wrote:
> On Thu, Jul 16, 2015 at 10:30:48AM +0200, Teresa Remmet wrote:
>> phyCORE-AM335x is a SoM (System on Module) containing
>> a AM335x SOC. The module can be connected to different
>> carrier boards.
>>
>> Some hardware parts are configurable on the phyCORE-AM335x.
>> So they are disabled on default in this som dtsi file.
>> They will be enabled in the board dts files, when populated.
>>
>> * RAM up to 1GiB
>> * PMIC
>> * NAND flash up to 1GiB
>> * Eth PHY on SOM: 1x RMII
>> * SPI NOR flash 8MiB (optional)
>> * i2c RTC (optional)
>> * i2c EEPROM 4kiB (optional)
>>
>> Signed-off-by: Teresa Remmet <t.remmet@phytec•de>
>> ---
>> arch/arm/boot/dts/am335x-phycore-som.dtsi | 368 ++++++++++++++++++++++++++++++
>> 1 file changed, 368 insertions(+)
>> create mode 100644 arch/arm/boot/dts/am335x-phycore-som.dtsi
>>
>> diff --git a/arch/arm/boot/dts/am335x-phycore-som.dtsi b/arch/arm/boot/dts/am335x-phycore-som.dtsi
>> new file mode 100644
>> index 0000000..4d28fc3
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/am335x-phycore-som.dtsi
[...]
>> +#include "am33xx.dtsi"
>> +
>> +/ {
>> + model = "Phytec AM335x phyCORE";
>> + compatible = "phytec,am335x-phycore-som", "ti,am33xx";
>
> One minor thing here...wildcards in compatible strings aren't permitted.
> However, family compatibles like "ti,am33xx" that came in before this
> was enforced are grandfathered. Ideally, the newly introced board/som
> specific strings should not propagate that wildcard. i.e. something
> like "phytec,am3352-phycore-som" or whatever is the base family part
> on these SOMs.
>
I'm not sure this is wild card.
I tend to think that it is the real name of the som [1], no?
http://phytec.com/products/system-on-modules/phycore/am335x/
[...]
--
Regards,
Igor.
next prev parent reply other threads:[~2015-07-28 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 8:30 [PATCH 1/2] ARM: dts: Add support for phyCORE-AM335x SoM Teresa Remmet
2015-07-16 8:30 ` [PATCH 2/2] ARM: dts: Add phyBOARD-WEGA-AM335x rdk Teresa Remmet
2015-07-21 10:59 ` [PATCH 1/2] ARM: dts: Add support for phyCORE-AM335x SoM Tony Lindgren
2015-07-27 14:34 ` Matt Porter
2015-07-28 8:29 ` Igor Grinberg [this message]
2015-07-28 8:47 ` Teresa Remmet
2015-07-28 12:24 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B73D6D.2040801@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox