From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 0/3] Add DT support for netxbig LEDs
Date: Tue, 28 Jul 2015 12:30:07 +0200 [thread overview]
Message-ID: <55B759AF.8050304@free-electrons.com> (raw)
In-Reply-To: <55B3F580.2040207@gmail.com>
Hi Jacek, Simon,
On 25/07/2015 22:45, Jacek Anaszewski wrote:
> I confused two patch sets. Everything I wrote in the reply
> below was related to leds-ns2 [1] patch set.
About taking the dts part of this patch set in the led branch, I agree.
It will solve the dependency problem I would have. Usually we (the mvebu
maintainer) take all the dts related to void the merge conflict.
For these ones, I don't expect any merge problem because they are all located
in dts and only in one family.
So you can also take "[PATCH v2 2/4] ARM: Kirkwood: add modes-map property to
ns2-leds nodes" with my
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
and I will remove this one from my branches.
Thanks,
Gregory
> When it is related to leds-netxbig driver - there was already
> version 3 posted [2], but it is not the final one, we are waiting
> for the update.
Right, I missed this third version.
>
> On 25.07.2015 21:36, Jacek Anaszewski wrote:
>> Hi Gregory,
>>
>> On 25.07.2015 16:54, Gregory CLEMENT wrote:
>>> Hi Simon, Bryan, Richard,
>>>
>>> On 18/06/2015 13:52, Simon Guinot wrote:
>>>> Hello,
>>>>
>>>> This patch series adds DT support for the LEDs found on the
>>>> Kirkwood-based
>>>> LaCie boards 2Big and 5Big Network v2.
>>>
>>> I saw that some led related patch on kirkwood based board have been
>>> merged.
>>> What is the status of this series?
>>
>> LED subsystem part has been merged to linux-next, since DTS files
>> are not required for the compilation to succeed. We've been waiting
>> for ARM/Marvell Kirkwood maintainer opinion to decide on how to proceed
>> regarding patch 2/4.
>>
>>> I still have the patch 2 and 3 in my inbox waiting for being applied.
>>
>> Patch 3 affects only drivers/leds/leds-ns2.c, you were probably
>> thinking of patch 1 which modifies the out of LED tree file
>> include/linux/platform_data/leds-kirkwood-ns2.h.
>>
>> IMO it would be best if the whole series went through the
>> LED tree.
>>
>>> Thanks,
>>>
>>> Gregory
>>>
>>>
>>>>
>>>> Changes since v1:
>>>> - Check timer mode value retrieved from DT.
>>>> - In netxbig_leds_get_of_pdata, don't use unsigned long variables to get
>>>> timer delay values from DT with function of_property_read_u32_index.
>>>> Instead, use a temporary u32 variable. This allows to silence a
>>>> static
>>>> checker warning.
>>>> - Make timer property optional in the binding documentation. It is now
>>>> aligned with the driver code.
>>>>
>>>> Simon
>>>>
>>>> Simon Guinot (3):
>>>> leds: netxbig: add device tree binding
>>>> ARM: Kirkwood: add LED DT entries for netxbig boards
>>>> ARM: mvebu: remove static LED setup for netxbig boards
>>>>
>>>> .../devicetree/bindings/gpio/netxbig-gpio-ext.txt | 22 ++
>>>> .../devicetree/bindings/leds/leds-netxbig.txt | 92 ++++++++
>>>> arch/arm/boot/dts/kirkwood-net5big.dts | 60 +++++
>>>> arch/arm/boot/dts/kirkwood-netxbig.dtsi | 80 +++++++
>>>> arch/arm/mach-mvebu/Kconfig | 7 -
>>>> arch/arm/mach-mvebu/Makefile | 1 -
>>>> arch/arm/mach-mvebu/board.h | 21 --
>>>> arch/arm/mach-mvebu/kirkwood.c | 4 -
>>>> arch/arm/mach-mvebu/netxbig.c | 191
>>>> ----------------
>>>> drivers/leds/leds-netxbig.c | 250
>>>> +++++++++++++++++++--
>>>> include/dt-bindings/leds/leds-netxbig.h | 18 ++
>>>> 11 files changed, 501 insertions(+), 245 deletions(-)
>>>> create mode 100644
>>>> Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt
>>>> create mode 100644
>>>> Documentation/devicetree/bindings/leds/leds-netxbig.txt
>>>> delete mode 100644 arch/arm/mach-mvebu/board.h
>>>> delete mode 100644 arch/arm/mach-mvebu/netxbig.c
>>>> create mode 100644 include/dt-bindings/leds/leds-netxbig.h
>>>>
>>>
>>>
>>
>
> [1]
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/353807.html
> [2]
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/351486.html
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2015-07-28 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 11:52 [PATCH v2 0/3] Add DT support for netxbig LEDs Simon Guinot
2015-06-18 11:52 ` [PATCH v2 1/3] leds: netxbig: add device tree binding Simon Guinot
2015-06-18 11:52 ` [PATCH v2 2/3] ARM: Kirkwood: add LED DT entries for netxbig boards Simon Guinot
2015-06-29 12:45 ` Gregory CLEMENT
2015-06-18 11:52 ` [PATCH v2 3/3] ARM: mvebu: remove static LED setup " Simon Guinot
2015-06-29 12:45 ` Gregory CLEMENT
2015-07-25 14:54 ` [PATCH v2 0/3] Add DT support for netxbig LEDs Gregory CLEMENT
2015-07-25 19:36 ` Jacek Anaszewski
2015-07-25 20:45 ` Jacek Anaszewski
2015-07-28 10:30 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B759AF.8050304@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox