From: d-gerlach@ti•com (Dave Gerlach)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 3/3] soc: ti: Add wkup_m3_ipc driver
Date: Tue, 4 Aug 2015 15:58:41 -0500 [thread overview]
Message-ID: <55C12781.1070007@ti.com> (raw)
In-Reply-To: <20150720061559.GX17550@atomide.com>
On 07/20/2015 01:16 AM, Tony Lindgren wrote:
> * Dave Gerlach <d-gerlach@ti•com> [150717 13:59]:
>> +
>> +/* Public functions */
> ...
>> +EXPORT_SYMBOL_GPL(wkup_m3_set_mem_type);
>> +EXPORT_SYMBOL_GPL(wkup_m3_set_resume_address);
>> +EXPORT_SYMBOL_GPL(wkup_m3_request_pm_status);
>> +EXPORT_SYMBOL_GPL(wkup_m3_prepare_low_power);
>> +EXPORT_SYMBOL_GPL(wkup_m3_finish_low_power);
>
> I think you can avoid exporting these SoC specific functions
> by just exporting wkup_m3_request() and wkup_m3_free() type
> functions with a data structure containing the necessary
> function pointers.
Ok thanks for the comment, I can try that change out, I agree it
probably isn't necessary to export so much.
Regards,
Dave
>
> Regards,
>
> Tony
>
prev parent reply other threads:[~2015-08-04 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 20:56 [PATCH v2 0/3] soc: ti: Introduce wkup_m3_ipc driver Dave Gerlach
2015-07-17 20:56 ` [PATCH v2 1/3] mailbox/omap: Add ti, mbox-send-noirq quirk to fix AM33xx CPU Idle Dave Gerlach
2015-08-05 10:28 ` Tony Lindgren
2015-08-05 15:32 ` [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq " Suman Anna
2015-08-06 6:29 ` [PATCH v2 1/3] mailbox/omap: Add ti, mbox-send-noirq " Tony Lindgren
2015-07-17 20:56 ` [PATCH v2 2/3] Documentation: dt: add bindings for TI Wakeup M3 IPC device Dave Gerlach
2015-07-17 20:56 ` [PATCH v2 3/3] soc: ti: Add wkup_m3_ipc driver Dave Gerlach
2015-07-20 6:16 ` Tony Lindgren
2015-08-04 20:58 ` Dave Gerlach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C12781.1070007@ti.com \
--to=d-gerlach@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox