From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH TRIVIAL] Enable GICv2m on ARM virt machine
Date: Fri, 07 Aug 2015 11:33:54 +0100 [thread overview]
Message-ID: <55C48992.6060700@arm.com> (raw)
In-Reply-To: <00f901d0d0fa$b8168770$28439650$@samsung.com>
On 07/08/15 11:20, Pavel Fedin wrote:
> Hello!
>
>> You may want to add a comment about the dependency chain that requires
>> the generic msi.h.
>
> The error i get is:
> --- cut ---
> In file included from kernel/irq/chip.c:14:0:
> include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory
> #include <asm/msi.h>
> ^
> --- cut ---
>
> This portion in linux/msi.h sits under #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN, which is activated by
> the following chain:
> ARM_GIC_V2M => PCI_MSI_IRQ_DOMAIN => GENERIC_MSI_IRQ_DOMAIN
>
> Do i need to respin just because of comment?
That's for Russell to decide, really. But I feel that adding an include
file that affects the whole architecture (and not just a single
platform) deserves an explanation in the commit log.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2015-08-07 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 9:59 [PATCH TRIVIAL] Enable GICv2m on ARM virt machine Pavel Fedin
2015-08-07 8:52 ` Marc Zyngier
2015-08-07 10:20 ` Pavel Fedin
2015-08-07 10:33 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C48992.6060700@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox