From: oliver+list@schinagl•nl (Olliver Schinagl)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating.
Date: Wed, 12 Aug 2015 16:57:27 +0200 [thread overview]
Message-ID: <55CB5ED7.40406@schinagl.nl> (raw)
In-Reply-To: <CAOMqctSdkPgDfBCNsGNsNnoh4GqVW59oZC3q9HX3gY_NneMPKw@mail.gmail.com>
The thing is, I never saw the prints in my console (i assume that it
prints on the console by default with earlyprintk/debug stuff enabled as
per sunxi-usual)?
P.S. what I do as a basic test, is on our very very minimal empty debian
image (think < 150 mb) i do a apt-get build-essential that installs
about 150mb worth of packages.
Without these patches, everything works as before. All packages
successfully installed. I can do more intense testing later, but I
figured that this is pretty intense.
Olliver
On 12-08-15 15:37, Michal Suchanek wrote:
> On 12 August 2015 at 15:19, Olliver Schinagl <oliver+list@schinagl•nl> wrote:
>> Hey,
>>
>> On 12-08-15 14:35, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 12-08-15 14:23, Michal Suchanek wrote:
>>>> When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable
>>>> automatic hardware controlled clock gating on the mmc interface.
>>>>
>>>> Signed-off-by: Michal Suchanek <hramrach@gmail•com>
>>>
>>> In general this looks good, but I wonder how intensively this has
>>> been tested ?
>> It doesn't matter actually, it took some time longer, but the mmc still
>> craps out even with Michal's 3 patches. I'll revert hans's earlier patch
>> again and do a bit more extensive testing.
> Does the oclk switch timeout even after 750ms?
>
> In some earlier tests I tried to enable/disable the clock repeatedly
> when it failed but it seemed to have little effect on the total time
> it took to disable the clock in the end.
>
> Maybe it would be worh trying to set the timeout to some insanely long
> value and test stability with that. I picked 750 as around twice the
> maximum time it ever took on my board.
>
> Thanks
>
> Michal
>
prev parent reply other threads:[~2015-08-12 14:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 12:10 [PATCH 0/3] misc MMC fixes Michal Suchanek
2015-08-12 12:23 ` [PATCH resend 1/3] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff michal.suchanek at ruk.cuni.cz
2015-08-12 12:32 ` Hans de Goede
2015-08-12 12:40 ` [linux-sunxi] " Olliver Schinagl
2015-08-12 13:04 ` Michal Suchanek
2015-08-12 13:29 ` [PATCH v3 " Michal Suchanek
2015-08-12 14:49 ` [linux-sunxi] " Hans de Goede
2015-08-25 12:06 ` Ulf Hansson
2015-08-12 12:23 ` [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic Michal Suchanek
2015-08-17 1:55 ` Jaehoon Chung
2015-08-17 5:52 ` Michal Suchanek
2015-08-17 11:26 ` Jaehoon Chung
2015-08-17 14:42 ` Alim Akhtar
2015-08-17 14:55 ` Michal Suchanek
2015-08-17 16:21 ` Alim Akhtar
2015-08-12 12:23 ` [PATCH 3/3] mmc: sunxi: use controller automatic clock gating Michal Suchanek
2015-08-12 12:35 ` [linux-sunxi] " Hans de Goede
2015-08-12 12:53 ` Michal Suchanek
2015-08-12 13:19 ` Olliver Schinagl
2015-08-12 13:37 ` Michal Suchanek
2015-08-12 14:57 ` Olliver Schinagl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB5ED7.40406@schinagl.nl \
--to=oliver+list@schinagl$(echo .)nl \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox