Subject: [PATCH v2 3/6] genirq: introduce irq_chip_set_type_parent() helper

From: [email-masked] (Sudeep Holla)
Date: Thu, 13 Aug 2015 09:58:20 +0100

On 12/08/15 18:45, Grygorii Strashko wrote:
> It's expected to use this helper when the current
> domain doesn't implement .irq_set_type(),  but expect
> the parent to do so.
>
> Signed-off-by: Grygorii Strashko <[email-masked]>
> ---
>   include/linux/irq.h |  1 +
>   kernel/irq/chip.c   | 20 ++++++++++++++++++++
>   2 files changed, 21 insertions(+)
>
> diff --git a/include/linux/irq.h b/include/linux/irq.h
> index 92188b0..51744bc 100644
> --- a/include/linux/irq.h
> +++ b/include/linux/irq.h
> @@ -484,6 +484,7 @@ extern int irq_chip_set_affinity_parent(struct irq_data *data,
>   extern int irq_chip_set_wake_parent(struct irq_data *data, unsigned int on);
>   extern int irq_chip_set_vcpu_affinity_parent(struct irq_data *data,
>   					     void *vcpu_info);
> +extern int irq_chip_set_type_parent(struct irq_data *data, unsigned int type);
>   #endif
>
>   /* Handling of unhandled and spurious interrupts: */
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index bdb1b9d..b48938b 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -985,6 +985,26 @@ int irq_chip_set_affinity_parent(struct irq_data *data,
>   }
>
>   /**
> + * irq_chip_set_type_parent - Set IRQ type on the parent interrupt
> + * @data:	Pointer to interrupt specific data
> + * @type:	IRQ_TYPE_{LEVEL,EDGE}_* value - see include/linux/irq.h
> + *
> + * Conditional, as the underlying parent chip might not implement it.
> + */
> +int irq_chip_set_type_parent(struct irq_data *data, unsigned int type)
> +{
> +	data = data->parent_data;
> +
> +	if (irq_data_get_irq_chip(data)->flags & IRQCHIP_SKIP_SET_WAKE)
> +		return 0;
> +

I think this is unrelated here(perhaps copy-paste error ?). I fail to
see how wakeup and trigger type are related.

Regards,
Sudeep