From: guohanjun@huawei•com (Hanjun Guo)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] Add ACPI bindings for the EHCI platform driver.
Date: Thu, 13 Aug 2015 19:50:08 +0800 [thread overview]
Message-ID: <55CC8470.5070007@huawei.com> (raw)
In-Reply-To: <1439416290-21228-4-git-send-email-jeremy.linton@arm.com>
Hi Jeremy,
Just minor comments below. (resend as it's blocked by mailist)
On 2015/8/13 5:51, Jeremy Linton wrote:
> This enables USB on the ARM juno board when booted with
> an ACPI kernel. The PNP id comes from the PNP/ACPI registry
> and describes a EHCI controller without debug.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm•com>
> ---
> drivers/usb/host/ehci-platform.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
> index 82e396f..1807baa 100644
> --- a/drivers/usb/host/ehci-platform.c
> +++ b/drivers/usb/host/ehci-platform.c
> @@ -27,6 +27,7 @@
> #include <linux/io.h>
> #include <linux/module.h>
> #include <linux/of.h>
> +#include <linux/acpi.h>
this file list the head file in alphabetical order, I think it's
better to follow that rule.
> #include <linux/phy/phy.h>
> #include <linux/platform_device.h>
> #include <linux/reset.h>
> @@ -382,6 +383,13 @@ static const struct of_device_id vt8500_ehci_ids[] = {
> };
> MODULE_DEVICE_TABLE(of, vt8500_ehci_ids);
>
> +static const struct acpi_device_id ehci_acpi_match[] = {
> + { "PNP0D20", 0 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, ehci_acpi_match);
> +
> +
Single empty line will be fine :)
> static const struct platform_device_id ehci_platform_table[] = {
> { "ehci-platform", 0 },
> { }
> @@ -400,6 +408,7 @@ static struct platform_driver ehci_platform_driver = {
> .name = "ehci-platform",
> .pm = &ehci_platform_pm_ops,
> .of_match_table = vt8500_ehci_ids,
> + .acpi_match_table = ACPI_PTR(ehci_acpi_match),
> }
> };
>
With that minor fixes,
Reviewed-by: Hanjun Guo <hanjun.guo@linaro•org>
Thanks
Hanjun
next prev parent reply other threads:[~2015-08-13 11:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 21:51 [PATCH 0/3] Enable EHCI-platform driver for use with ACPI Jeremy Linton
2015-08-12 21:51 ` [PATCH 1/3] Honor ACPI _CCA attribute setting Jeremy Linton
2015-08-14 1:45 ` Suravee Suthikulpanit
2015-08-14 13:14 ` Catalin Marinas
2015-08-14 14:12 ` Jeremy Linton
2015-08-18 3:36 ` Huang Shijie
2015-08-12 21:51 ` [PATCH 2/3] Display a DMA error message Jeremy Linton
2015-08-13 11:02 ` Hanjun Guo
2015-08-13 14:52 ` Alan Stern
2015-08-14 21:19 ` Arnd Bergmann
2015-08-14 21:44 ` Jeremy Linton
2015-08-14 21:56 ` Arnd Bergmann
2015-08-12 21:51 ` [PATCH 3/3] Add ACPI bindings for the EHCI platform driver Jeremy Linton
2015-08-13 11:50 ` Hanjun Guo [this message]
2015-08-13 14:45 ` Jeremy Linton
2015-08-13 14:53 ` Alan Stern
2015-08-13 15:13 ` Jeremy Linton
2015-08-18 3:35 ` Huang Shijie
2015-08-13 9:44 ` [PATCH 0/3] Enable EHCI-platform driver for use with ACPI Graeme Gregory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CC8470.5070007@huawei.com \
--to=guohanjun@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox