From: hverkuil@xs4all•nl (Hans Verkuil)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/4] [media] Media entity cleanups and build fixes
Date: Thu, 20 Aug 2015 14:41:40 +0200 [thread overview]
Message-ID: <55D5CB04.50508@xs4all.nl> (raw)
In-Reply-To: <1439998526-12832-1-git-send-email-javier@osg.samsung.com>
On 08/19/15 17:35, Javier Martinez Canillas wrote:
> Hello,
>
> This series contains a couple of build fixes and cleanups for the
> Media Controller framework. The goal of the series is to get rid of
> the struct media_entity .parent member since now that a media_gobj is
> embedded into entities, the media_gobj .mdev member can be used to
> store a pointer to the parent struct media_device.
>
> So the .parent field becomes redundant and can be removed after all
> the users are converted to use entity .graph_obj.mdev instead.
>
> Patches 1/4 and 2/4 are build fixes I found while build testing if no
> regressions were introduced by the conversion. Patch 3/4 converts
> all the drivers and the MC core to use .mdev instead of .parent and
> finally patch 4/4 removes the .parent field since now is unused.
Regarding patches 1 and 2: these should of course be merged with Mauro's
patches that make this particular change (patch 3/8), otherwise it would
break git bisect.
Anyway,
Acked-by: Hans Verkuil <hans.verkuil@cisco•com> for the changes in patch
1 and 2, as long as they are added to Mauro's patch 3/8.
Regards,
Hans
>
> The series depend on Mauro's "[PATCH v6 0/8] MC preparation patches
> series" [0].
>
> The transformation were automated using a coccinelle semantic patch
> and the drivers were build tested using allyesconfig and x-building
> the ARM Exynos and OMAP defconfigs + the needed media config options.
>
> Best regards,
> Javier
>
> [0]: http://www.mail-archive.com/linux-media at vger.kernel.org/msg91330.html
>
>
> Javier Martinez Canillas (4):
> [media] staging: omap4iss: get entity ID using media_entity_id()
> [media] omap3isp: get entity ID using media_entity_id()
> [media] media: use entity.graph_obj.mdev instead of .parent
> [media] media: remove media entity .parent field
>
> drivers/media/media-device.c | 8 ++---
> drivers/media/media-entity.c | 34 ++++++++++++----------
> drivers/media/platform/exynos4-is/fimc-isp-video.c | 6 ++--
> drivers/media/platform/exynos4-is/fimc-lite.c | 8 ++---
> drivers/media/platform/exynos4-is/media-dev.c | 2 +-
> drivers/media/platform/exynos4-is/media-dev.h | 8 ++---
> drivers/media/platform/omap3isp/isp.c | 11 ++++---
> drivers/media/platform/omap3isp/ispccdc.c | 2 +-
> drivers/media/platform/omap3isp/ispvideo.c | 10 ++++---
> drivers/media/platform/vsp1/vsp1_video.c | 2 +-
> drivers/media/platform/xilinx/xilinx-dma.c | 2 +-
> drivers/staging/media/davinci_vpfe/vpfe_video.c | 6 ++--
> drivers/staging/media/omap4iss/iss.c | 6 ++--
> drivers/staging/media/omap4iss/iss_video.c | 4 +--
> include/media/media-entity.h | 1 -
> 15 files changed, 58 insertions(+), 52 deletions(-)
>
next prev parent reply other threads:[~2015-08-20 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 15:35 [PATCH 0/4] [media] Media entity cleanups and build fixes Javier Martinez Canillas
2015-08-19 15:35 ` [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent Javier Martinez Canillas
2015-08-20 12:43 ` Hans Verkuil
2015-08-20 12:41 ` Hans Verkuil [this message]
2015-08-20 12:50 ` [PATCH 0/4] [media] Media entity cleanups and build fixes Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D5CB04.50508@xs4all.nl \
--to=hverkuil@xs4all$(echo .)nl \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox