From: rjui@broadcom•com (Ray Jui)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 05/18] ARM: BCM: use const and __initconst for smp_operations
Date: Mon, 24 Aug 2015 13:24:26 -0700 [thread overview]
Message-ID: <55DB7D7A.5070704@broadcom.com> (raw)
In-Reply-To: <55DB6379.7040009@gmail.com>
On 8/24/2015 11:33 AM, Florian Fainelli wrote:
> On 23/08/15 21:36, Masahiro Yamada wrote:
>> The smp_operations structure is not over-written, so add const
>> qualifier and replace __initdata with __initconst.
>>
>> Also, add static to bcm63138_smp_ops.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext•com>
>
> For bcm63xx and brcmstb:
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail•com>
>
>> ---
>>
>> arch/arm/mach-bcm/bcm63xx_smp.c | 2 +-
>> arch/arm/mach-bcm/kona_smp.c | 2 +-
>> arch/arm/mach-bcm/platsmp-brcmstb.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/mach-bcm/bcm63xx_smp.c b/arch/arm/mach-bcm/bcm63xx_smp.c
>> index 19be904..9b6727e 100644
>> --- a/arch/arm/mach-bcm/bcm63xx_smp.c
>> +++ b/arch/arm/mach-bcm/bcm63xx_smp.c
>> @@ -161,7 +161,7 @@ static void __init bcm63138_smp_prepare_cpus(unsigned int max_cpus)
>> }
>> }
>>
>> -struct smp_operations bcm63138_smp_ops __initdata = {
>> +static const struct smp_operations bcm63138_smp_ops __initconst = {
>> .smp_prepare_cpus = bcm63138_smp_prepare_cpus,
>> .smp_boot_secondary = bcm63138_smp_boot_secondary,
>> };
>> diff --git a/arch/arm/mach-bcm/kona_smp.c b/arch/arm/mach-bcm/kona_smp.c
>> index 66a0465..da8328b 100644
>> --- a/arch/arm/mach-bcm/kona_smp.c
>> +++ b/arch/arm/mach-bcm/kona_smp.c
>> @@ -194,7 +194,7 @@ static int bcm_boot_secondary(unsigned int cpu, struct task_struct *idle)
>> return -ENOSYS;
>> }
>>
>> -static struct smp_operations bcm_smp_ops __initdata = {
>> +static const struct smp_operations bcm_smp_ops __initconst = {
>> .smp_prepare_cpus = bcm_smp_prepare_cpus,
>> .smp_boot_secondary = bcm_boot_secondary,
>> };
The change to kona_smp.c looks fine to me.
Signed-off-by: Ray Jui <rjui@broadcom•com>
Thanks,
Ray
next prev parent reply other threads:[~2015-08-24 20:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 4:36 [PATCH 00/18] ARM: use const and __initconst for smp_operations Masahiro Yamada
2015-08-24 4:36 ` [PATCH 01/18] ARM: add const qualifier to the argument of smp_set_ops() Masahiro Yamada
2015-08-24 20:33 ` Stephen Boyd
2015-08-24 4:36 ` [PATCH 02/18] ARM: add const qualifier to smp_operations member in structures Masahiro Yamada
2015-08-24 4:36 ` [PATCH 03/18] ARM: alpine: use const and __initconst for smp_operations Masahiro Yamada
2015-08-24 4:36 ` [PATCH 04/18] ARM: axxia: " Masahiro Yamada
2015-08-24 4:36 ` [PATCH 05/18] ARM: BCM: " Masahiro Yamada
2015-08-24 18:33 ` Florian Fainelli
2015-08-24 20:24 ` Ray Jui [this message]
2015-08-24 4:36 ` [PATCH 06/18] ARM: berlin: " Masahiro Yamada
2015-08-24 4:36 ` [PATCH 07/18] ARM: EXYNOS: " Masahiro Yamada
2015-08-24 7:17 ` Krzysztof Kozlowski
2015-08-24 4:36 ` [PATCH 08/18] ARM: hisi: do not export smp_operations structures Masahiro Yamada
2015-08-24 4:36 ` [PATCH 09/18] ARM: hisi: use const and __initconst for smp_operations Masahiro Yamada
2015-08-24 4:36 ` [PATCH 10/18] ARM: mvebu: " Masahiro Yamada
2015-08-24 4:36 ` [PATCH 11/18] ARM: qcom: " Masahiro Yamada
2015-08-24 19:36 ` Andy Gross
2015-08-24 4:36 ` [PATCH 12/18] ARM: rockchip: " Masahiro Yamada
2015-08-24 4:36 ` [PATCH 13/18] ARM: socfpga: " Masahiro Yamada
2015-08-24 4:36 ` [PATCH 14/18] ARM: sunxi: " Masahiro Yamada
2015-08-24 6:22 ` Maxime Ripard
2015-08-24 4:36 ` [PATCH 15/18] ARM: uniphier: " Masahiro Yamada
2015-08-24 4:36 ` [PATCH 16/18] ARM: zx: " Masahiro Yamada
2015-08-24 4:36 ` [PATCH 17/18] ARM: zynq: " Masahiro Yamada
2015-08-24 19:58 ` Moritz Fischer
2015-08-24 4:36 ` [PATCH 18/18] ARM: mcpm: " Masahiro Yamada
2015-08-24 21:12 ` [PATCH 00/18] ARM: " Olof Johansson
2015-08-24 21:21 ` Russell King - ARM Linux
2015-08-24 21:44 ` Olof Johansson
2015-08-25 1:37 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DB7D7A.5070704@broadcom.com \
--to=rjui@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox